Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CloudControllerManagerNetworking values in config helm chart #107

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Set CloudControllerManagerNetworking values in config helm chart #107

merged 1 commit into from
Jan 3, 2025

Conversation

defo89
Copy link
Contributor

@defo89 defo89 commented Jan 3, 2025

Proposed Changes

  • ccm configmap is configured via cloud-provider-config chart, hence we need to set the values there
  • also fix tests

@defo89 defo89 added the bug Something isn't working label Jan 3, 2025
@defo89 defo89 requested review from SchwarzM and Nuckal777 January 3, 2025 14:46
@defo89 defo89 requested a review from a team as a code owner January 3, 2025 14:46
SchwarzM
SchwarzM approved these changes Jan 3, 2025
View reviewed changes
Copy link

@SchwarzM SchwarzM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@defo89 defo89 merged commit f99ef6c into main Jan 3, 2025
9 checks passed
@defo89 defo89 deleted the fix/fix-ccm-config-chart-values branch January 3, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchwarzM SchwarzM SchwarzM approved these changes

@Nuckal777 Nuckal777 Awaiting requested review from Nuckal777

Assignees
No one assigned
Labels
bug Something isn't working controllers size/L
Projects
Metal Automation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@defo89 @SchwarzM