Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Network Peering in apinetlet and metalnetlet #262

Merged
merged 9 commits into from
May 14, 2024
Merged

Handle Network Peering in apinetlet and metalnetlet #262

merged 9 commits into from
May 14, 2024

Conversation

kasabe28
Copy link
Contributor

@kasabe28 kasabe28 commented Mar 14, 2024 •
edited
Loading

Proposed Changes

  • Modify network controller in apinetlet to handle peerings
  • Add tests for network peering in apinetlet
  • Modify metalnetlet network controller to add peeredIDs
  • Modify test for metalnet network

Fixes #251

@github-actions github-actions bot added enhancement New feature or request size/XL labels Mar 14, 2024
@github-actions github-actions bot added size/XXL and removed size/XL labels Mar 15, 2024
@kasabe28 kasabe28 marked this pull request as ready for review March 18, 2024 09:10
@kasabe28 kasabe28 requested a review from a team as a code owner March 18, 2024 09:10
@kasabe28 kasabe28 force-pushed the enh/network-peering branch from 83b9a99 to 701c85a Compare March 26, 2024 08:14
@github-actions github-actions bot added size/XL documentation Improvements or additions to documentation and removed size/XXL labels Mar 26, 2024
@afritzler
Copy link
Member

As ironcore-dev/ironcore#1026 has been merged now, we can bump the ironcore dep and adjust the status of the network peering.

@kasabe28 kasabe28 requested a review from afritzler April 5, 2024 13:55
@balpert89
Copy link
Contributor

currently blocked by ironcore-dev/metalnet#189

@github-actions github-actions bot added size/XXL and removed size/XL labels May 6, 2024
@kasabe28 kasabe28 force-pushed the enh/network-peering branch 2 times, most recently from c1da5b3 to 8f4a3f0 Compare May 6, 2024 14:00
@kasabe28 kasabe28 requested review from balpert89 and afritzler May 7, 2024 09:37
@afritzler
Copy link
Member

@kasabe28 the PR looks good. Can you please rebase the PR branch?

@kasabe28 kasabe28 force-pushed the enh/network-peering branch from 8f4a3f0 to 950a19b Compare May 14, 2024 12:30
@afritzler afritzler changed the title Implement Network Peering in apinetlet and metalnetlet Handle Network Peering in apinetlet and metalnetlet May 14, 2024
@afritzler afritzler merged commit 265fd46 into main May 14, 2024
12 checks passed
@afritzler afritzler deleted the enh/network-peering branch May 14, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

@balpert89 balpert89 Awaiting requested review from balpert89

Assignees

@ushabelgur ushabelgur

@kasabe28 kasabe28

Labels
documentation Improvements or additions to documentation enhancement New feature or request size/XXL
Projects
Core
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Peering Translation in apinetlet and metalnetlet
4 participants
@kasabe28 @afritzler @balpert89 @ushabelgur