Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Network Peering translation in apinetlet and metalnetlet with Peering Prefix #306

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Enhance Network Peering translation in apinetlet and metalnetlet with Peering Prefix #306

merged 4 commits into from
Jul 15, 2024

Conversation

kasabe28
Copy link
Contributor

@kasabe28 kasabe28 commented Jul 8, 2024

Proposed Changes

  • Add PeeringPrefix type
  • Modify apinetlet NetworkController to translate ironcore Prefixes into ironcore-net Prefixes.
  • Modify metalnetlet NetworkController to translate ironcore-net Prefixes into metalnet Prefixes.
  • Add/Modify corresponding tests.
  • Update docs

Fixes #305

@kasabe28 kasabe28 self-assigned this Jul 8, 2024
@kasabe28 kasabe28 requested a review from a team as a code owner July 8, 2024 06:24
@github-actions github-actions bot added size/XL bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jul 8, 2024
@afritzler afritzler self-requested a review July 8, 2024 08:07
afritzler
afritzler requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - can you please rebase this PR branch

@kasabe28 kasabe28 force-pushed the enh/nw_peering_prefix branch from be00cbc to 501b7e8 Compare July 15, 2024 06:00
@afritzler afritzler merged commit f4a5494 into main Jul 15, 2024
11 checks passed
@afritzler afritzler deleted the enh/nw_peering_prefix branch July 15, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

@kasabe28 kasabe28

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request size/XL
Projects
Core
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Network Peering translation in apinetlet and metalnetlet with Peering Prefix
3 participants
@kasabe28 @afritzler @ushabelgur