Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate schemes in apinetlet into managerScheme and apinetletScheme #310

Closed
wants to merge 6 commits into from

Conversation

balpert89
Copy link
Contributor

Fixes #309

@github-actions github-actions bot added size/XL bug Something isn't working labels Jul 29, 2024
@balpert89
Copy link
Contributor Author

@sujeet01 @Rohit-0505 https://github.com/ironcore-dev/ironcore-net/pull/310/files#diff-cd513991cc10b556eb34e9aa31ffbe2e3090219f8ff47f0688ea2e07250a2db3R665-R673 these enqueue funcs produce the following error:
2024-07-29T12:45:28Z ERROR controller-runtime.source.EventHandler kind must be registered to the Scheme {"error": "no kind is registered for the type v1alpha1.Network in scheme \"pkg/runtime/scheme.go:100\""}

The other controllers are running as expected, please have a look and fix.

@afritzler hope the styling is okay, my formatter is a bit more picky :)

Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @balpert89 for you PR. Can we please keep the method signature and invocation in a single line as we have this code style everywhere else. Only when the parameters are going over 100 chars we typically put them on individual lines.

cmd/apinetlet/main.go Outdated Show resolved Hide resolved
cmd/apinetlet/main.go Outdated Show resolved Hide resolved
apinetlet/controllers/virtualip_controller.go Outdated Show resolved Hide resolved
apinetlet/controllers/loadbalancer_controller.go Outdated Show resolved Hide resolved
apinetlet/controllers/natgateway_controller.go Outdated Show resolved Hide resolved
apinetlet/controllers/network_controller.go Outdated Show resolved Hide resolved
apinetlet/controllers/network_controller.go Outdated Show resolved Hide resolved
apinetlet/controllers/network_controller.go Outdated Show resolved Hide resolved
apinetlet/controllers/network_controller.go Outdated Show resolved Hide resolved
apinetlet/controllers/network_controller.go Outdated Show resolved Hide resolved
@afritzler afritzler changed the title Fix/separate mgr apinetlet scheme Separate schemes in apinetlet into managerScheme and apinetletScheme Jul 29, 2024
@balpert89
Copy link
Contributor Author

@sujeet01 will continue from here

@github-actions github-actions bot added size/M and removed size/XL labels Jul 30, 2024
@balpert89
Copy link
Contributor Author

closing this one as agreed we do not need the scheme changes and so on.

@balpert89 balpert89 closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate schemes in apinetlet into managerScheme and apinetletScheme
4 participants