-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate schemes
in apinetlet
into managerScheme
and apinetletScheme
#310
Conversation
@sujeet01 @Rohit-0505 https://github.com/ironcore-dev/ironcore-net/pull/310/files#diff-cd513991cc10b556eb34e9aa31ffbe2e3090219f8ff47f0688ea2e07250a2db3R665-R673 these enqueue funcs produce the following error: The other controllers are running as expected, please have a look and fix. @afritzler hope the styling is okay, my formatter is a bit more picky :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @balpert89 for you PR. Can we please keep the method signature and invocation in a single line as we have this code style everywhere else. Only when the parameters are going over 100 chars we typically put them on individual lines.
schemes
in apinetlet
into managerScheme
and apinetletScheme
@sujeet01 will continue from here |
closing this one as agreed we do not need the scheme changes and so on. |
Fixes #309