Fix watch setup in the NetworkPolicy reconciler of the apinetlet
#313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afritzler
changed the title
NetworkPolicy reconcilerNetworkPolicy reconciler of the apinetlet
afritzler
force-pushed
the
fix/np-watch-setup
branch
2 times, most recently
from
9161a7b to
dbd998b
Compare
In order to support proper cross-cluster watches, we need to use the `apiNetCache` in our watch setup of the reconciler.
afritzler
force-pushed
the
fix/np-watch-setup
branch
from
dbd998b to
83bda9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In order to support proper cross-cluster watches, we need to use the
apiNetCachein our watch setup of the reconciler.