Implement Network peering controller and extend `NetworkPeeringStat…

…us` with `State` field (#1026)

* Extend NetworkPeeringStatus with State field

* Implement network peering controller and add tests

* change network peering status state name from Initial to Pending

* modify network protection controller to keep finalizer if it has valid peering

* fix claimer key creation in network release controller

api/networking/v1alpha1/network_type.go

@@ -68,10 +68,22 @@ type NetworkStatus struct {
 // +enum
 type NetworkState string
 
+// NetworkPeeringState is the state a NetworkPeering can be in
+type NetworkPeeringState string
+
+const (
+	// NetworkPeeringStatePending signals that the network peering is not applied.
+	NetworkPeeringStatePending NetworkPeeringState = "Pending"
+	// NetworkPeeringStateApplied signals that the network peering is applied.
+	NetworkPeeringStateApplied NetworkPeeringState = "Applied"
+)
+
 // NetworkPeeringStatus is the status of a network peering.
 type NetworkPeeringStatus struct {
 	// Name is the name of the network peering.
 	Name string `json:"name"`
+	// State represents the network peering state
+	State NetworkPeeringState `json:"state,omitempty"`
 }
 
 const (

cmd/ironcore-controller-manager/main.go

@@ -76,6 +76,7 @@ const (
 	loadBalancerController                       = "loadbalancer"
 	loadBalancerEphemeralPrefixController        = "loadbalancerephemeralprefix"
 	networkProtectionController                  = "networkprotection"
+	networkPeeringController                     = "networkpeering"
 	networkReleaseController                     = "networkrelease"
 	networkInterfaceEphemeralPrefixController    = "networkinterfaceephemeralprefix"
 	networkInterfaceEphemeralVirtualIPController = "networkinterfaceephemeralvirtualip"
@@ -341,6 +342,15 @@ func main() {
 		}
 	}
 
+	if controllers.Enabled(networkPeeringController) {
+		if err := (&networkingcontrollers.NetworkPeeringReconciler{
+			Client: mgr.GetClient(),
+		}).SetupWithManager(mgr); err != nil {
+			setupLog.Error(err, "unable to create controller", "controller", "NetworkPeering")
+			os.Exit(1)
+		}
+	}
+
 	if controllers.Enabled(networkReleaseController) {
 		if err := (&networkingcontrollers.NetworkReleaseReconciler{
 			Client:       mgr.GetClient(),
@@ -523,6 +533,13 @@ func main() {
 		}
 	}
 
+	if controllers.AnyEnabled(networkProtectionController) {
+		if err := networkingclient.SetupNetworkSpecPeeringClaimRefNamesFieldIndexer(ctx, mgr.GetFieldIndexer()); err != nil {
+			setupLog.Error(err, "unable to setup field indexer", "field", networkingclient.NetworkSpecPeeringClaimRefNamesField)
+			os.Exit(1)
+		}
+	}
+
 	if controllers.AnyEnabled(networkInterfaceEphemeralPrefixController) {
 		if err := networkingclient.SetupNetworkInterfacePrefixNamesFieldIndexer(ctx, mgr.GetFieldIndexer()); err != nil {
 			setupLog.Error(err, "unable to setup field indexer", "field", networkingclient.NetworkInterfacePrefixNamesField)

internal/apis/networking/network_type.go

@@ -68,10 +68,22 @@ type NetworkStatus struct {
 // +enum
 type NetworkState string
 
+// NetworkPeeringState is the state a NetworkPeering can be in.
+type NetworkPeeringState string
+
+const (
+	// NetworkPeeringStatePending signals that the network peering is not applied.
+	NetworkPeeringStatePending NetworkPeeringState = "Pending"
+	// NetworkPeeringStateApplied signals that the network peering is applied.
+	NetworkPeeringStateApplied NetworkPeeringState = "Applied"
+)
+
 // NetworkPeeringStatus is the status of a network peering.
 type NetworkPeeringStatus struct {
 	// Name is the name of the network peering.
 	Name string
+	// State represents the network peering state
+	State NetworkPeeringState
 }
 
 const (

internal/client/networking/network.go

@@ -0,0 +1,28 @@
+// SPDX-FileCopyrightText: 2023 SAP SE or an SAP affiliate company and IronCore contributors
+// SPDX-License-Identifier: Apache-2.0
+
+package networking
+
+import (
+	"context"
+
+	"github.com/ironcore-dev/ironcore/api/networking/v1alpha1"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+)
+
+const NetworkSpecPeeringClaimRefNamesField = "network-spec-peering-claim-ref-names"
+
+func SetupNetworkSpecPeeringClaimRefNamesFieldIndexer(ctx context.Context, indexer client.FieldIndexer) error {
+	return indexer.IndexField(ctx, &v1alpha1.Network{}, NetworkSpecPeeringClaimRefNamesField, func(obj client.Object) []string {
+		network := obj.(*v1alpha1.Network)
+		peeringClaimRefNames := make([]string, 0, len(network.Spec.PeeringClaimRefs))
+		for _, peeringClaimRef := range network.Spec.PeeringClaimRefs {
+			peeringClaimRefNames = append(peeringClaimRefNames, peeringClaimRef.Name)
+		}
+
+		if len(peeringClaimRefNames) == 0 {
+			return []string{""}
+		}
+		return peeringClaimRefNames
+	})
+}