Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang to 1.22.2 and other housekeeping tasks #1053

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Bump golang to 1.22.2 and other housekeeping tasks #1053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,35 +4,45 @@ updates:
- package-ecosystem: "gomod"
directory: "/"
schedule:
interval: "daily"
open-pull-requests-limit: 10
interval: "weekly"
reviewers:
- "ironcore-dev/core"
# Ignore K8 packages as these are done manually
ignore:
- dependency-name: "k8s.io/api"
- dependency-name: "k8s.io/apiextensions-apiserver"
- dependency-name: "k8s.io/apimachinery"
- dependency-name: "k8s.io/apiserver"
- dependency-name: "k8s.io/client-go"
- dependency-name: "k8s.io/component-base"
- dependency-name: "k8s.io/kube-aggregator"
- dependency-name: "k8s.io/kubectl"
- dependency-name: "sigs.k8s.io/controller-runtime"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"
interval: "weekly"
open-pull-requests-limit: 10
reviewers:
- "ironcore-dev/core"
- package-ecosystem: "pip"
directory: "/docs"
schedule:
interval: "daily"
interval: "weekly"
open-pull-requests-limit: 10
reviewers:
- "ironcore-dev/core"
- package-ecosystem: "docker"
directory: "/docs"
schedule:
interval: "daily"
interval: "weekly"
open-pull-requests-limit: 10
reviewers:
- "ironcore-dev/core"
- package-ecosystem: "docker"
directory: "/"
schedule:
interval: "daily"
interval: "weekly"
open-pull-requests-limit: 10
reviewers:
- "ironcore-dev/core"
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v4
with:
version: v1.55.2
version: v1.57.2
2 changes: 1 addition & 1 deletion .github/workflows/release-drafter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
push:
branches:
- main
pull_request:
pull_request_target:
types: [ opened, reopened, synchronize ]
workflow_dispatch:

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/size-label.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Size Label

on:
pull_request:
pull_request_target:
types:
- opened
- edited
Expand Down
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,12 +375,12 @@ GOLANGCI_LINT ?= $(LOCALBIN)/golangci-lint
KUSTOMIZE_VERSION ?= v5.1.1
CODE_GENERATOR_VERSION ?= v0.29.0
VGOPATH_VERSION ?= v0.1.3
CONTROLLER_TOOLS_VERSION ?= v0.13.0
CONTROLLER_TOOLS_VERSION ?= v0.14.0
GEN_CRD_API_REFERENCE_DOCS_VERSION ?= v0.3.0
ADDLICENSE_VERSION ?= v1.1.1
PROTOC_GEN_GOGO_VERSION ?= v1.3.2
GOIMPORTS_VERSION ?= v0.13.0
GOLANGCI_LINT_VERSION ?= v1.55.2
GOIMPORTS_VERSION ?= v0.20.0
GOLANGCI_LINT_VERSION ?= v1.57.2
OPENAPI_EXTRACTOR_VERSION ?= v0.1.4

KUSTOMIZE_INSTALL_SCRIPT ?= "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh"
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/ironcore-dev/ironcore

go 1.21
go 1.22.2

require (
github.com/bits-and-blooms/bitset v1.13.0
Expand Down
8 changes: 4 additions & 4 deletions internal/admission/plugin/volumeresizepolicy/admission_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ var _ = Describe("Admission", func() {
By("patching the Volume to increase the Volume size")
volumeBase := volume.DeepCopy()
volume.Spec.Resources[corev1alpha1.ResourceStorage] = resource.MustParse("2Gi")
Expect(k8sClient.Patch(ctx, volume, client.MergeFrom(volumeBase))).Should(
MatchError(apierrors.NewBadRequest("VolumeClass ResizePolicy does not allow resizing")))
Expect(k8sClient.Patch(ctx, volume, client.MergeFrom(volumeBase))).To(
MatchError(apierrors.NewBadRequest("VolumeClass ResizePolicy does not allow resizing").Error()))

By("ensuring that Volume has been resized")
Consistently(Object(volume)).Should(SatisfyAll(
Expand Down Expand Up @@ -141,8 +141,8 @@ var _ = Describe("Admission", func() {
By("patching the Volume to decrease the Volume size")
volumeBase := volume.DeepCopy()
volume.Spec.Resources[corev1alpha1.ResourceStorage] = resource.MustParse("1Gi")
Expect(k8sClient.Patch(ctx, volume, client.MergeFrom(volumeBase))).Should(
MatchError(apierrors.NewBadRequest("VolumeClass ResizePolicy does not allow shrinking")))
Expect(k8sClient.Patch(ctx, volume, client.MergeFrom(volumeBase))).To(
MatchError(apierrors.NewBadRequest("VolumeClass ResizePolicy does not allow shrinking").Error()))

By("ensuring that Volume has been resized")
Consistently(Object(volume)).Should(SatisfyAll(
Expand Down