Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for NetworkPeeringClaimRef field of Network type #1074

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Add validation for NetworkPeeringClaimRef field of Network type #1074

merged 2 commits into from
Jun 20, 2024

Conversation

kasabe28
Copy link
Contributor

Proposed Changes

  • Add validations for PeeringClaimRefs of Network type.
  • Add tests for PeeringClaimRefs validations of Network type.

Fixes #1073

@kasabe28 kasabe28 self-assigned this Jun 17, 2024
@kasabe28 kasabe28 requested a review from a team as a code owner June 17, 2024 12:11
afritzler
afritzler requested changes Jun 18, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
internal/apis/networking/validation/network.go Outdated Show resolved Hide resolved
@afritzler
Copy link
Member

Btw. we don't need to validate types.UID as this is a build in type and the serializer will take care of the validation.

@kasabe28 kasabe28 force-pushed the add-peering-claims-validation branch from e10cc73 to 0fbebc3 Compare June 18, 2024 12:45
@github-actions github-actions bot added size/M and removed size/L labels Jun 18, 2024
@afritzler afritzler changed the title Add validations for NetworkPeeringClaimRef fields of Network type Add validation for NetworkPeeringClaimRef field of Network type Jun 20, 2024
@afritzler afritzler merged commit ecbffc1 into main Jun 20, 2024
10 checks passed
@afritzler afritzler deleted the add-peering-claims-validation branch June 20, 2024 11:47
@afritzler afritzler added the enhancement New feature or request label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

@kasabe28 kasabe28

Labels
enhancement New feature or request size/M
Projects
Core
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validations for NetworkPeeringClaimRef fields of Network type
2 participants
@kasabe28 @afritzler