Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e example for Machine creation using ephemeral resources #1136

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Add e2e example for Machine creation using ephemeral resources #1136

merged 3 commits into from
Nov 11, 2024

Conversation

Rohit-0505
Copy link
Contributor

@Rohit-0505 Rohit-0505 commented Oct 22, 2024 •
edited by afritzler
Loading

Proposed Changes

  • Add e2e example manifests for machine creation using ephemeral volume and networkinterface

/ref #1129

@Rohit-0505 Rohit-0505 requested a review from a team as a code owner October 22, 2024 04:59
@github-actions github-actions bot added size/L documentation Improvements or additions to documentation enhancement New feature or request labels Oct 22, 2024
@Rohit-0505 Rohit-0505 changed the title Add e2e example for Machine creation using non ephemeral resources Add e2e example for Machine creation using ephemeral resources Oct 22, 2024
@Rohit-0505 Rohit-0505 self-assigned this Oct 22, 2024
afritzler
afritzler requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we name the sample folder machine-with-ephemeral resources? This naming scheme would fit better to the existing e2e examples.

@Rohit-0505 Rohit-0505 force-pushed the enh/e2e-machine-ephemeral branch from ae861fd to 328107f Compare October 28, 2024 10:52
@Rohit-0505
Copy link
Contributor Author

Can we name the sample folder machine-with-ephemeral resources? This naming scheme would fit better to the existing e2e examples.

done

@Rohit-0505 Rohit-0505 force-pushed the enh/e2e-machine-ephemeral branch 3 times, most recently from 5c5ed5f to 4948e99 Compare October 31, 2024 06:56
@Rohit-0505 Rohit-0505 force-pushed the enh/e2e-machine-ephemeral branch from 2ff1210 to febbc19 Compare November 6, 2024 05:36
@afritzler afritzler merged commit 97703e1 into main Nov 11, 2024
13 checks passed
@afritzler afritzler deleted the enh/e2e-machine-ephemeral branch November 11, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

@Rohit-0505 Rohit-0505

Labels
documentation Improvements or additions to documentation enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rohit-0505 @afritzler