Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize rest config setup for brokers #1176

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Harmonize rest config setup for brokers #1176

merged 2 commits into from
Dec 3, 2024

Conversation

ushabelgur
Copy link
Contributor

Proposed Changes

  • Harmonize rest config setup for brokers similar to poollets.
  • Remove dependency from "github.com/ironcore-dev/controller-utils/configutils"

Fixes #1175

@ushabelgur ushabelgur requested a review from a team as a code owner December 2, 2024 09:16
@github-actions github-actions bot added the size/L label Dec 2, 2024
@ushabelgur ushabelgur requested review from balpert89, lukasfrank and afritzler and removed request for a team December 2, 2024 09:20
@afritzler afritzler added the enhancement New feature or request label Dec 3, 2024
@afritzler afritzler merged commit ccbc073 into ironcore-dev:main Dec 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

@lukasfrank lukasfrank lukasfrank approved these changes

@balpert89 balpert89 Awaiting requested review from balpert89

Assignees
No one assigned
Labels
enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harmonize *rest.Config setup for brokers and poollets
3 participants
@ushabelgur @afritzler @lukasfrank