Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for machine network interface #1217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add validation for machine network interface #1217

wants to merge 1 commit into from

Conversation

ushabelgur
Copy link
Contributor

Proposed Changes

  • Add validation for machine spec network interface
    (Note: NetworkInterface already has the validation for IP sources length i.e. only single IP is allowed

    ironcore/internal/apis/networking/validation/networkinterface.go

    Line 143 in 6bbca96

    if !prefix.IsSingleIP() {

    added missing validation for machine spec networkInterface which will cover prefixLength validation as well)

Fixes #1186

@github-actions github-actions bot added size/L bug Something isn't working labels Jan 13, 2025
@ushabelgur ushabelgur marked this pull request as ready for review January 13, 2025 09:35
@ushabelgur ushabelgur requested a review from a team as a code owner January 13, 2025 09:35
@balpert89
Copy link
Contributor

LGTM

@lukas016 lukas016 force-pushed the osc/fix/prefix_length branch from d33d454 to 7e996ad Compare January 15, 2025 05:18
@ushabelgur ushabelgur self-assigned this Jan 15, 2025
afritzler
afritzler requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add in the test cases an ephemeral NIC which derives it's IP from a parent prefix with a length of 32/128 (this will be valid) and values which are greater than this and those will be invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler requested changes

@balpert89 balpert89 Awaiting requested review from balpert89

Assignees

@ushabelgur ushabelgur

Labels
bug Something isn't working size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate PrefixLength for IPSource to ensure a length of 32/128
3 participants
@ushabelgur @balpert89 @afritzler