Add proposal for snapshot support #802
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce `Snapshot` and `SnapshotClass` resources to allow users to take point-in-time snapshots of the content of a `Volume` - Enhance the `Volume` resource to include a `dataSource` field for restoring data from a snapshot - Improve data protection and disaster recovery capabilities - Provide support for different types of snapshots based on `VolumePool` capabilities - The proposal does not modify existing `VolumePool` resources - The `Snapshot` resource is not designed to provide a complete backup or archival solution for `Volumes` - The actual creation and readiness of a snapshot can depend on various factors such as `Volume` size, `VolumePool` capabilities, and infrastructure performance - The `Snapshot` resource and restoration path are meant to be additional tools in the data protection toolbox, not to replace existing comprehensive disaster recovery and data protection solutions Signed-off-by: Andreas Fritzler <[email protected]>
github-actions
bot
added
size/L
documentation
|
We have discussed the PR internally and do not see a problem with going forward as-is. We do not recommend going forward with the mentioned alternatives as its either off-loading significant portions to the user (3rd party provider), complicate interaction (storage provider APIs) or restrict flexibility (adding to |
kasabe28
reviewed
Dec 1, 2023
| volumeRef: | ||
| name: example-volume | ||
| snapshotClassRef: | ||
| name: example-snapshotclass |
There was a problem hiding this comment.
Can we also have encryption support for Snapshot as Volume encryption support is there?
There was a problem hiding this comment.
I would expect a transitive behavior here. If the volume is encrypted, the snapshot should be encrypted as well. Plus, the option to encrypt the snapshot explicitly.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
SnapshotandSnapshotClassresources to allow users to take point-in-time snapshots of the content of aVolumeVolumeresource to include adataSourcefield for restoring data from a snapshotVolumePoolcapabilitiesVolumePoolresourcesSnapshotresource is not designed to provide a complete backup or archival solution forVolumesVolumesize,VolumePoolcapabilities, and infrastructure performanceSnapshotresource and restoration path are meant to be additional tools in the data protection toolbox, not to replace existing comprehensive disaster recovery and data protection solutionsFixes #801