Populate NetworkInterface status via machinepoollet
#961
+228
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afritzler
changed the title
NetworkInterface status via machinepoollet
afritzler
changed the title
NetworkInterface status via machinepoolletNetworkInterface status via machinepoollet
afritzler
force-pushed
the
enh/nic-status
branch
from
721f3df to
824a73f
Compare
lukasfrank
reviewed
Jan 16, 2024
afritzler
force-pushed
the
enh/nic-status
branch
from
824a73f to
6f8b3f6
Compare
afritzler
force-pushed
the
enh/nic-status
branch
5 times, most recently
from
6164150 to
868c97f
Compare
In the current implementation the NIC status {State,IPs} is not updated
by the `machinepoollet`. This leads to the problem that a NIC which is
`Available` is not being represented correctly in it's status. This PR
changes the `machinepoollet` logic in a way, that it populates effective
IPs to the NIC status and transitions the NIC state to `Available` if
the NIC could be provisioned successfully.
afritzler
force-pushed
the
enh/nic-status
branch
from
868c97f to
a7625a4
Compare
lukasfrank
approved these changes
Jan 17, 2024
afritzler
added a commit
that referenced
this pull request
Dec 18, 2024
Rollback #961 as it causes a race between ironcore and ironcore-net controllers constantly updating the NIC IP status.
lukasfrank
pushed a commit
that referenced
this pull request
Dec 18, 2024
Rollback #961 as it causes a race between ironcore and ironcore-net controllers constantly updating the NIC IP status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In the current implementation the NIC status {State,IPs} is not updated by the
machinepoollet. This leads to the problem that a NIC which isAvailableis not being represented correctly in it's status. This PR changes themachinepoolletlogic in a way, that it populates effective IPs to the NIC status and transitions the NIC state toAvailableif the NIC could be provisioned successfully.