Claim only PoweredOff Servers
#159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also do not perform power changes in `Available` state if server is already powered off. ServerClaim controller may patch the server in parallell to `spec.PowerState: On` which may result in powerin on the server in Available state
afritzler
approved these changes
Oct 31, 2024
afritzler
requested changes
Oct 31, 2024
afritzler
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also do not perform power changes in
Availablestate if server is already powered off.ServerClaim controller may patch the server in parallel to
spec.PowerState: Onwhich may result in powering on the server in Available state.