Add metal user and SSH Keypair during Discovery boot
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a feature to create a `metal` user with corresponding SSH keypairs which are stored as a `Secret` alongside the discovery `ServerBootConfiguration`. The `Secret` is named `<serverbootconfig.name-ssh>`. This allows an administrator to use the private key in this `Secret` to SSH into the `Server` in case something went wrong when running the `metalprobe` agent.
Nuckal777
requested changes
Jan 16, 2025
| Image: r.ProbeImage, | ||
| Flags: flags, | ||
| func generateSSHKeyPairs() ([]byte, []byte, error) { | ||
| privateKey, err := rsa.GenerateKey(rand.Reader, 2048) |
There was a problem hiding this comment.
Could we consider ed25519 or 4096-bit keys?
There was a problem hiding this comment.
We can make this configurable later. RSA was easier because there helper method to validate the correctness of the key.
afritzler
force-pushed
the
enh/discovery-ssh
branch
2 times, most recently
from
5d9e762 to
8173057
Compare
afritzler
force-pushed
the
enh/discovery-ssh
branch
from
8173057 to
4d4f041
Compare
Nuckal777
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR introduces a feature to create a
metaluser with a corresponding SSH keypair which is stored as aSecretalongside the discoveryServerBootConfiguration. TheSecretis named<serverbootconfig.name-ssh>. This allows an administrator to use the private key in thisSecretto SSH into theServerin case something went wrong when running themetalprobeagent.The
Secretis being removed again once theServerBootConfigurationfor the discovery boot has been removed after a successfulServeronboarding.Fixes #217