Drop kube-rbac-proxy container and adopt controller-runtime native …
#243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas016
force-pushed
the
osc/enh/replace-kube-rbac-proxy
branch
6 times, most recently
from
21063b8 to
77e5ca1
Compare
…authn/authz for metrics
lukas016
force-pushed
the
osc/enh/replace-kube-rbac-proxy
branch
4 times, most recently
from
311d7b1 to
01146ca
Compare
lukas016
force-pushed
the
osc/enh/replace-kube-rbac-proxy
branch
from
01146ca to
618a1fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The PR removes the soon-to-be deprecated
kube-rbac-proxycontainer dependency and replaces it withController-Runtime'sbuilt-in authn/authz for securing the metrics endpoint. This simplifies setup, enhances security, and follows the latest Kubebuilder best practices.Key Changes
for ex:controller-manager and metalprobe docker imagesFixes #209
Ref:
kubernetes-sigs/kubebuilder#3907
kubernetes-sigs/controller-runtime#2407
kubernetes-sigs/kubebuilder#4400
kubernetes-sigs/kubebuilder/docs/reference/metrics (v4.5.0)