Update netlink to self-maintained latest version #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @byteocean . Looks like the new version doesnt contain the commit which changes the go version in go.mod. (commit id: 1ca7c35) The functionality we use in this netlink library somehow (re-)tested after being rebased to its upstream main branch ? I see that you have a test case in the self maintained repo exercising this part, I assume that it was run successfully ? |
byteocean
force-pushed
the
fix/netlink_version
branch
from
ab00cbb to
868e91a
Compare
byteocean
force-pushed
the
fix/netlink_version
branch
from
868e91a to
fa78ea1
Compare
|
This corresponding change is now merged to the upstream netlink, but a new release still needs to be published by them. before that, the package needs to point to the version where the commit gets merged. We can finally get rid of the package replacement statement. |
|
Great news !! |
guvenc
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it would be nice to get rid of the package replacement for netlink. But before the maintainers of netlink respond to the new request to merge the change, it would be necessary to keep the self-maintained netlink lib up-to-date.