Add network peering status #217
Conversation
github-actions
bot
added
size/L
documentation
| ID: network.Spec.ID, | ||
| State: metalnetv1alpha1.NetworkPeeringStateReady, | ||
| })))) | ||
|
|
There was a problem hiding this comment.
In order to exercise a bit more of the newly added functionality. Can we also remove the peering and check the status was correctly updated ?
If a peering is removed then the status will completely disappear right ? So that expectation can be tested here as well.
There was a problem hiding this comment.
Done added test case for peering removal case.
ushabelgur
force-pushed
the
enh/network_peering_status
branch
4 times, most recently
from
ab6a515 to
d42d42c
Compare
|
|
||
| Expect(networkReconcile(ctx, *network)).To(Succeed()) | ||
|
|
||
| By("defining NetworkInterface object to use created network") |
There was a problem hiding this comment.
Do we really need to create a NetworkInterface for the peering test?
There was a problem hiding this comment.
Yes we need it, this is the reply i had got from guvence: We need to create at least one NetworkInterface or LoadBalancer in the network/VNI then only ownVniAvail becomes true. If there is no object in the Network/VNI on that dpservice then there is nothing to peer.
| Expect(networkReconcile(ctx, *network2)).To(Succeed()) | ||
|
|
||
| By("defining a new NetworkInterface object to use created network") | ||
| networkInterface2 := &metalnetv1alpha1.NetworkInterface{ |
| func (r *NetworkReconciler) patchStatus(ctx context.Context, network *metalnetv1alpha1.Network, mutate func()) error { | ||
| base := network.DeepCopy() | ||
|
|
||
| mutate() |
There was a problem hiding this comment.
What is the purpose of this mutate() function?
There was a problem hiding this comment.
It it just calling the function we are passing as a parameter to this PatchStatus method(Basically updating status)
r.patchStatus(ctx, network, func() { network.Status.Peerings = newStatusPeerings });
Just to keep it consistent with other parts of the metalnet code, i have used patch method like, otherwise we can use our usual way of patching.
ushabelgur
force-pushed
the
enh/network_peering_status
branch
from
d42d42c to
54a14b1
Compare
ushabelgur
force-pushed
the
enh/network_peering_status
branch
from
54a14b1 to
afabf60
Compare
Proposed Changes
Fixes #189