Only reconcile ip objects with specific label #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5kt
force-pushed
the
feat/filter-label
branch
from
503b5bb to
931b1a0
Compare
Gchbg
approved these changes
Feb 15, 2024
Gchbg
force-pushed
the
feat/filter-label
branch
from
931b1a0 to
93845c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We'd like to reconcile ip.ipam object with specific labels specified by subnet-label-name and subnet-label-value cmdline arguments. Not specifying them will keep the behaviour as before reconciling every ip.ipam object from the namespace.
Which issue(s) this PR fixes:
Fixes #