unpack: open file handle only once #142
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a significant speed boost, specially when doing chown and utimes operations, by reducing the number of fd open+close ops.
Note: this PR is still WIP while I figure out why tests are failing. It looks like error handling needs to change and the stuff you see for handling errors right now is mostly me flopping around trying to figure out the issue.
This PR is inspired by yarnpkg/yarn#4486, which did this for Yarn's own extraction and it had a pretty neat speed boost! 🎉
Benchmarks
Before
After