Add nodata attribute to Raster #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regardless of the raster datatype, the nodata value is always a floating-point value (even for integer- & complex-valued rasters). See: * OSGeo/gdal#808 * rasterio/rasterio#1747
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 90.36% 90.47% +0.11%
==========================================
Files 7 7
Lines 415 420 +5
==========================================
+ Hits 375 380 +5
Misses 40 40 ☔ View full report in Codecov by Sentry. |
Older versions of rasterio don't know about 64-bit integer dtypes. Support for int64 was added in rasterio 1.3.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to set (when creating the Raster) and get the "nodata" value from Raster objects.
It seems most intuitive that the "nodata" value should have the same dtype as the Raster image data. However, due to underlying limitations in GDAL/rasterio12, the nodata value must be a
float, even if the raster is integer- or complex-valued.Footnotes
https://github.com/OSGeo/gdal/pull/808 ↩
https://github.com/rasterio/rasterio/issues/1747 ↩