Replicate live search optimization heuristic to the repositories page

Turns out searches without trigrams can even be slow on the repos page!
isker · Nov 14, 2023 · 37dacde · 37dacde
1 parent 41bb950
commit 37dacde
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/.changeset/good-eels-call.md b/.changeset/good-eels-call.md
@@ -0,0 +1,5 @@
+---
+"neogrok": patch
+---
+
+Replicate live search optimization heuristic to the repositories page
diff --git a/src/routes/repositories/search-form.svelte b/src/routes/repositories/search-form.svelte
@@ -46,9 +46,7 @@
 
 <form
   on:submit|preventDefault={() => {
-    if ($searchType === "manual") {
-      manualSubmit();
-    }
+    manualSubmit();
   }}
 >
   <!-- Make enter key submission work: https://stackoverflow.com/a/35235768 -->
@@ -71,7 +69,11 @@
       <input
         bind:value={query}
         on:input={() => {
-          if ($searchType === "live") {
+          if (
+            $searchType === "live" &&
+            // Same trigram efficiency rules as on the main search page.
+            (!query || query.length >= 3)
+          ) {
             updateRouteListQuery({ query, searchType: $searchType });
           }
         }}