Skip to content

Commit

Permalink
refactor: improve pagination button styles and ensure correct slide c…
Browse files Browse the repository at this point in the history
…alculation
  • Loading branch information
ismail9k committed Jan 8, 2025
1 parent 563f6fc commit 19d1fed
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 15 deletions.
26 changes: 12 additions & 14 deletions src/components/Pagination/Pagination.css
Original file line number Diff line number Diff line change
Expand Up @@ -21,29 +21,23 @@
}

.carousel__pagination-button {
background: transparent;
border: 0;
cursor: pointer;
display: block;
margin: 0;
padding: var(--vc-pgn-margin);
}

.carousel__pagination-button--active::after {
background-color: var(--vc-pgn-active-color);
}

.carousel__pagination-button::after {
margin: var(--vc-pgn-margin);
background-color: var(--vc-pgn-background-color);
border-radius: var(--vc-pgn-border-radius);
content: '';
display: block;
height: var(--vc-pgn-height);
width: var(--vc-pgn-width);
padding: 0;
}

.carousel__pagination-button--active {
background-color: var(--vc-pgn-active-color);
}

@media (hover: hover) {
.carousel__pagination-button:hover::after {
.carousel__pagination-button:hover {
background-color: var(--vc-pgn-active-color);
}
}
Expand All @@ -57,8 +51,12 @@
transform: translateY(50%);
}

.carousel__pagination-button::after {
.carousel__pagination-button {
height: var(--vc-pgn-width);
width: var(--vc-pgn-height);
}
}

.carousel.is-btt .carousel__pagination {
flex-direction: column-reverse;
}
2 changes: 1 addition & 1 deletion src/components/Pagination/Pagination.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const Pagination = defineComponent<PaginationProps>({
onClick: () =>
carousel.nav.slideTo(
isPaginated.value
? slide * +carousel.config.itemsToShow + offset.value
? Math.floor(slide * +carousel.config.itemsToShow + offset.value)

Check warning on line 86 in src/components/Pagination/Pagination.ts

View workflow job for this annotation

GitHub Actions / coverage-report

This line is not covered by a test
: slide
),
})
Expand Down

0 comments on commit 19d1fed

Please sign in to comment.