two numerical bug fixes

istefanis · Feb 2, 2024 · 4443730 · 4443730
1 parent c4cd07a
commit 4443730
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/math/computerAlgebra/dataTypes/reals.js b/math/computerAlgebra/dataTypes/reals.js
@@ -6,6 +6,7 @@
  * Math / ComputerAlgebra / DataTypes / Reals
  */
 
+import { isZeroWithinTolerance } from "../../../util/commons.js";
 import { set } from "../algebraicOperations.js";
 
 /**
@@ -21,7 +22,7 @@ export const loadRealsOperations = function () {
 
   //BUGFIX
   set(["negate", "real"], (x) => -x);
-  set(["isZero", "real"], (x) => x === 0);
+  set(["isZero", "real"], (x) => isZeroWithinTolerance(x));
 
   set(["gcd", "real", "real"], (a, b) => gcdReals(a, b));
 

diff --git a/util/commons.js b/util/commons.js
@@ -33,6 +33,10 @@ export const roundDecimal = function (x, digits) {
   return +x.toFixed(digits);
 };
 
+export const isZeroWithinTolerance = function (x) {
+  return Math.abs(x) < 10 ** -10;
+};
+
 //
 // Polynomial
 //

diff --git a/view/plots/nyquistPlot.js b/view/plots/nyquistPlot.js
@@ -171,6 +171,10 @@ export default class NyquistPlot {
     // const minImag = Math.min(...imags);
     // const maxImag = Math.max(...imags);
 
+    //set limits for coordinates of plotted points
+    const xMax = 10 ** 4;
+    const yMax = 10 ** 4;
+
     //create the plot
     const nyquistPlot = functionPlot({
       target: `#${this.#nyquistPlotDomElement.id}`,
@@ -196,15 +200,15 @@ export default class NyquistPlot {
         // },
         {
           points: this.#curvePoints
-            .filter((x) => x[0] > 0)
+            .filter((x) => x[0] > 0 && x[1] < xMax && x[2] < yMax)
             .map((x) => [x[1], x[2]]),
           // color: "red",
           fnType: "points",
           graphType: "polyline",
         },
         {
           points: this.#curvePoints
-            .filter((x) => x[0] < 0)
+            .filter((x) => x[0] < 0 && x[1] > -xMax && x[2] > -yMax)
             .map((x) => [x[1], x[2]]),
           fnType: "points",
           graphType: "polyline",