Various changes to perf code #3037
Draft
+57
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
istio-testing
added
do-not-merge/work-in-progress
Stevenjin8
force-pushed
the
perf/small-fixes
branch
from
092512b
to
3c7086c
Compare
Stevenjin8
commented
Sep 23, 2024
| @@ -55,12 +56,13 @@ function setup_test() { | |||
| --set rbac.enabled="${RBAC_ENABLED}" \ | |||
| --set namespace="${NAMESPACE}" \ | |||
| --set loadGenType="${LOAD_GEN_TYPE}" \ | |||
| --set excludeOutboundIPRanges=$(pod_ip_range)\ | |||
| --set includeOutboundIPRanges=$(svc_ip_range) \ | |||
There was a problem hiding this comment.
Had trouble on cncf cluster with services being assigned to IPs outside this range
There was a problem hiding this comment.
can you split this into another PR?
There was a problem hiding this comment.
I gotta rebase and change the title. The rustfilt stuff is already merged
Stevenjin8
changed the title
Stevenjin8
force-pushed
the
perf/small-fixes
branch
5 times, most recently
from
48a81ab
to
a65a20b
Compare
Stevenjin8
force-pushed
the
perf/small-fixes
branch
from
a65a20b
to
643546c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.