[chore] Refactor all classes to hooks #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/dip-trasformazione-digitale/design-react-kit/C9HHJtWGSBBvriZhzr9eJhFLWzNN |
dej611
changed the title
|
Just for SEO context I'll address here how I made it pass the treeshake check with
|
sanyamdogra
reviewed
Dec 28, 2021
src/Accordion/AccordionBody.tsx
Outdated
| export type AccordionBodyProps = Partial<TransitionProps> & { | ||
| tag?: ElementType; | ||
| className?: string; | ||
| active?: boolean; | ||
| onToggle?: () => void; | ||
| }; | ||
|
|
||
| // Taken from Reactstrap utils.js which are tken from bootstrap sass | ||
| export const TransitionTimeouts = { |
There was a problem hiding this comment.
Shouldn't we move these to some shared const files and then consume these? These appear to be generic
src/Accordion/AccordionBody.tsx
Outdated
| }; | ||
|
|
||
| // taken from Reactstrap utils.js | ||
| export const TransitionsKeys = [ |
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
+ Coverage 95.28% 97.05% +1.77%
==========================================
Files 237 237
Lines 2608 2617 +9
Branches 476 471 -5
==========================================
+ Hits 2485 2540 +55
+ Misses 123 77 -46
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@baldoalessandro this PR is passing the treeshake check but the bash script is not catching that up correctly. Can you have a look at that? |
|
@dej611 Sure thing, if I find something should I add commits here or open a new PR? UpdateI've found the issue and made a PR to test it in my fork, you can see it here baldoalessandro#5 |
You can create a PR here that targets this PR/branch. |
|
@baldoalessandro I've borrowed your fix for #830 as I was already fixing some stuff in the area. EDIT: |
|
@dej611 no problem 👍
- name: Fail if cannot tree-shake
if: ${{ steps.agadoo.outputs.status == 'not tree-shakeable' }}
run: exit 1in case there are still errors I'm happy to help you! |
It was reporting success all the times, as RET was not correctly capturing the correct output from agadoo. So I rewrote the script a bit to read the last line of the output |
|
Check tree-shakeability for 3751833: 🌳 tree-shakeable Agadoo stdoutimport 'reactstrap';
import 'react-use-navscroll';
import 'react';
import 'classnames';
import 'react-transition-group';
import 'react-stickup';
import 'is-number';
import 'bootstrap-italia/dist/assets/resizer-3x2.svg';
import 'react-select';
import 'react-toastify';Agadoo stderrnpx: installed 6 in 2.092s
'reactstrap' is imported by dist/esm/index.js, but could not be resolved – treating it as an external dependency
'react-use-navscroll' is imported by dist/esm/index.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/index.js, but could not be resolved – treating it as an external dependency
'classnames' is imported by dist/esm/index.js, but could not be resolved – treating it as an external dependency
'react-transition-group' is imported by dist/esm/index.js, but could not be resolved – treating it as an external dependency
'react-stickup' is imported by dist/esm/index.js, but could not be resolved – treating it as an external dependency
'is-number' is imported by dist/esm/index.js, but could not be resolved – treating it as an external dependency
'bootstrap-italia/dist/assets/resizer-3x2.svg' is imported by dist/esm/index.js, but could not be resolved – treating it as an external dependency
'react-select' is imported by dist/esm/index.js, but could not be resolved – treating it as an external dependency
'react-toastify' is imported by dist/esm/index.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItArrowDownCircle-ed01958f.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItArrowDown-f935c404.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItArrowDownTriangle-43e14d4e.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItArrowLeftCircle-022f3cd0.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItArrowLeftTriangle-85ad190a.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItArrowLeft-0eb29da6.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItArrowRightCircle-004ceffe.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItArrowRightTriangle-2270d70b.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItArrowRight-ea38dca9.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItArrowUpCircle-c58494d6.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItArrowUpTriangle-a3d220d7.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItArrowUp-4da728d9.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItBan-eed8efa1.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItBehance-7cfa1aa8.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItBookmark-bbd0a6eb.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItBox-c57a00d9.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItBurger-a48f8693.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItCalendar-4ced1f4f.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItCamera-ea37a275.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItCard-08e35364.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItChartLine-4d19c837.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItCheckCircle-80464fda.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItCheck-b13dfb47.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItChevronLeft-9e6f642c.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItChevronRight-5d8994f9.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItClip-5625b723.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItClock-e99f09d6.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItCloseBig-48385084.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItCloseCircle-e9aa8a4e.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItClose-da35711d.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItCodeCircle-f1a1174b.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItCollapse-7eeb99ff.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItComment-a939362d.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItCopy-a064bc7e.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItDelete-49e04a94.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItDesignersItalia-a7e1e47e.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItDownload-223fddb3.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItError-6411ebd1.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItExchangeCircle-b2e80da1.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItExpand-b9bf051e.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItExternalLink-3839a562.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItFacebookSquare-5d1a9e56.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItFacebook-a587f690.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItFile-713e7067.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItFiles-f13caaef.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItFlag-818a6c3e.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItFlickrSquare-f0eccb5c.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItFlickr-a1ae3080.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItFolder-46e3c66c.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItFullscreen-fd759316.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItFunnel-fcb6dbeb.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItGithub-ea460a17.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItHearing-6a6a24b1.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItHelpCircle-5ac93785.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItHelp-271b034b.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItHorn-779c3634.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItInbox-7d3124b3.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItInfoCircle-ecce1964.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItInstagram-a22a92f7.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItKey-27cc1af3.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItLessCircle-5fd48c2f.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItLink-d67a489f.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItLinkedinSquare-0c3cdc22.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItLinkedin-9cfc3fae.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItList-8d490e85.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItLock-9d50d11c.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItLocked-f6436368.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMail-df1e741a.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMapMarkerCircle-563223f9.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMapMarkerMinus-edb3574a.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMapMarkerPlus-da25d79c.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMapMarker-b63f733c.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMaximizeAlt-3b44dd74.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMaximize-8a293b02.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMediumSquare-6de2cbd2.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMedium-fda5c30a.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMinimize-eb2ef1b9.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMinusCircle-a4ad8e7e.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMinus-f14df53a.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMoreActions-1a78b8bd.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItMoreItems-994f3a0f.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItNote-e3b62893.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItOpenSource-63a1d44f.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItPa-8303599f.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItPasswordInvisible-6905b324.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItPasswordVisible-24431639.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItPencil-653ba0f7.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItPiattaforme-88f0e33e.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItPin-6afe491b.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItPlug-307dee08.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItPlusCircle-088c90ce.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItPlus-adeccea9.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItPresentation-1145d3ea.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItPrint-385582c1.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItRefresh-d4630557.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItRestore-d4706243.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItRssSquare-cf0e5940.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItRss-546f5827.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItSearch-78977d22.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItSettings-26f72896.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItShare-3f639a55.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItSoftware-59a24bb3.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItStarFull-e7491d5b.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItStarOutline-802e6204.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItTool-e87380ab.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItTwitterSquare-3f1a6138.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItTwitter-47ea4eb7.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItUnlocked-ce1c89be.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItUpload-b224e070.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItUser-dc34de8e.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItVideo-62f9a455.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItWarningCircle-cb2a4dd8.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItWarning-c5264ce7.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItWhatsappSquare-f557e07b.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItWhatsapp-02928732.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItWifi-ce1648c9.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItYoutube-291b7a7a.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItZoomIn-35bcda8e.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItZoomOut-dcb3a379.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItTelephone-3447b069.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItTelegram-7bb55bce.js, but could not be resolved – treating it as an external dependency
'react' is imported by dist/esm/ItTeamDigitale-5a025df7.js, but could not be resolved – treating it as an external dependency
Success! dist/esm/index.js is fully tree-shakeable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
masterbranch.Short description of what this resolves:
Complete the code refactoring from class to hooks.
Some extras:
useFontLoaderto use as replacement of theFontLoadercomponent.reactstrapas internal functionsreactstrapas static internal valuesPasswordInput🔥