-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(net): Make ListenConfig Parameterized #40
Comments
Does it mean refactor like this? It seems a change in the discv5 repo? #[derive(Clone, Debug)]
pub enum ListenConfig<T: Into<IpAddr> = IpAddr> {
Ip {
ip: T,
port: u16,
},
DualStack {
ipv4: T,
ipv4_port: u16,
ipv6: T,
ipv6_port: u16,
},
} |
Ah yes sorry for causing confusion, I see how that wording can be misinterpreted. What I meant was the We'd like to "parameterize" this by adding a Since the entire network stack is constructed using the top-level builder, which builds the discovery service, we should probably add the Effectively this "parameterizes" the listen config since a downstream user of the |
Ok, can I pick this? |
Certainly! |
Description
#34 introduces peer discovery, configuring discv5 to listen to a specified socket address.
This ticket is to refactor out the
ListenConfig
so that it can be parameterized.The text was updated successfully, but these errors were encountered: