Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListenConfig parametrization #54

Merged
merged 2 commits into from
Aug 29, 2024
Merged

ListenConfig parametrization #54

merged 2 commits into from
Aug 29, 2024

Conversation

GrapeBaBa
Copy link
Contributor

@GrapeBaBa GrapeBaBa commented Aug 28, 2024 •
edited
Loading

Fix #40

  1. This PR separate gossip addr and discovery addr, if discovery addr not set, will use gossip addr instead.
  2. Set the Enr ip and port.

GrapeBaBa
GrapeBaBa commented Aug 28, 2024
View reviewed changes
crates/net/src/builder.rs Outdated Show resolved Hide resolved
refcell
refcell requested changes Aug 28, 2024
View reviewed changes
crates/net/src/builder.rs Outdated Show resolved Hide resolved
@GrapeBaBa GrapeBaBa force-pushed the listen_config branch 2 times, most recently from 3f991bb to bdcf76e Compare August 29, 2024 07:37
@GrapeBaBa GrapeBaBa marked this pull request as ready for review August 29, 2024 07:53
refcell
refcell approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💯

crates/net/src/builder.rs Show resolved Hide resolved
@refcell refcell merged commit 3bf2d48 into ithacaxyz:main Aug 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(net): Make ListenConfig Parameterized
2 participants
@GrapeBaBa @refcell