向下兼容 Windows XP系统, 使用vc141_xp平台工具集编译通过. #606
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ithewei
reviewed
Aug 14, 2024
| @@ -52,8 +52,14 @@ static inline bool atomic_flag_test_and_set(atomic_flag* p) { | |||
| return InterlockedCompareExchange((LONG*)&p->_Value, 1, 0); | |||
| } | |||
|
|
|||
| #define ATOMIC_ADD InterlockedAdd | |||
| #define ATOMIC_SUB(p, n) InterlockedAdd(p, -n) | |||
| #if WINVER > 0x0600 | |||
There was a problem hiding this comment.
严格来讲应该是>=0x0600，0x0600是Windows Vista，也是有InterlockedAdd的
There was a problem hiding this comment.
嗯，了解， 但 vs 选择 vc141_xp 的时候， WINVER 的值就是 0x600 . 所以我取了这个值。
There was a problem hiding this comment.
这里暂时不合并吧， libhv 里面使用了太多的 windows xp没有的API函数。 要让其真正兼容windows xp 工作量不小。
本次虽然能在 vc141_xp 下编译通过，但在xp系统中运行 有很多函数都没有。
inet_ntop inet_pton GetTickCount64 SetFileCompletionNotificationModes InitializeSRWLock AcquireSRWLockShared ReleaseSRWLockShared AcquireSRWLockExclusive ReleaseSRWLockExclusive 等.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在windows xp系统下 使用 InterlockedExchangeAdd 替代 InterlockedAdd API.