release: 4.0.0

.github/workflows/static-analysis.yaml

@@ -12,8 +12,8 @@ jobs:
         strategy:
             matrix:
                 include:
-                    -   php-version: 8.1
                     -   php-version: 8.2
+                    -   php-version: 8.3
         steps:
             -   uses: actions/checkout@v2
 
@@ -36,4 +36,4 @@ jobs:
 
             -   run: composer install --no-progress
 
-            -   run: vendor/bin/phpstan analyse Classes -c phpstan.neon
+            -   run: vendor/bin/phpstan analyse Classes -c phpstan.neon

CHANGELOG.md

@@ -7,6 +7,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [4.0.0] - 2024-11-22 v13 Support
+
+### Added
+
+- TYPO3 13 support
+
+### Changed
+
+- Breaking: Filepond uploads are now handled by a different endpoint, check your FileopondConfig.html if you have overridden the template
+
+### Removed
+
+- Dropped support for v12
+
 ## [3.0.6] - 2024-11-22 Bugfix Release
 
 ### Added

Classes/Command/AnonymizeApplicationsCommand.php

@@ -36,6 +36,7 @@
 	use TYPO3\CMS\Core\Resource\Exception\InvalidFileNameException;
 	use TYPO3\CMS\Extbase\Persistence\Exception\InvalidQueryException;
 	use TYPO3\CMS\Extbase\Persistence\Generic\PersistenceManager;
+	use ITX\Jobapplications\Service\ConfigurationLoaderService;
 
 	/**
 	 * Task for deleting all applications older than a specific amount of time
@@ -49,16 +50,19 @@ class AnonymizeApplicationsCommand extends Command
 		public int $days = 90;
 		public int $status = 0;
 
+		protected ConfigurationLoaderService $configurationLoaderService;
 		protected PersistenceManager $persistenceManager;
 		protected ApplicationRepository $applicationRepository;
 		protected ApplicationFileService $applicationFileService;
 
-		public function __construct(PersistenceManager     $persistenceManager,
-									ApplicationRepository  $applicationRepository,
-									ApplicationFileService $applicationFileService,
-									LoggerInterface        $logger
+		public function __construct(ConfigurationLoaderService	$configurationLoaderService,
+									PersistenceManager     		$persistenceManager,
+									ApplicationRepository  		$applicationRepository,
+									ApplicationFileService 		$applicationFileService,
+									LoggerInterface        		$logger
 		)
 		{
+			$this->configurationLoaderService = $configurationLoaderService;
 			$this->persistenceManager = $persistenceManager;
 			$this->applicationRepository = $applicationRepository;
 			$this->applicationFileService = $applicationFileService;
@@ -86,6 +90,14 @@ public function configure()
 		 */
 		public function execute($input, $output): int
 		{
+			/*
+			 *	Issue: 	Repositories currently can't be used in TYPO3 v13 inside commands,
+			 * 			unless the ConfigurationManager is loaded in manually. This function
+			 *			does that for us.
+			 *	Link:	https://forge.typo3.org/issues/105616
+			 */
+			$this->configurationLoaderService->initCliEnvironment();
+
 			$anonymizeChars = "***";
 			$days = $input->getArgument('days') ?? 90;
 			$withStatus = $input->getOption('withStatus') ?? false;

Classes/Command/CleanUpApplicationsCommand.php

@@ -36,6 +36,7 @@
 	use TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException;
 	use TYPO3\CMS\Extbase\Persistence\Exception\InvalidQueryException;
 	use TYPO3\CMS\Extbase\Persistence\Generic\PersistenceManager;
+	use ITX\Jobapplications\Service\ConfigurationLoaderService;
 
 	/**
 	 * Task for deleting all applications older than a specific amount of time
@@ -46,15 +47,18 @@ class CleanUpApplicationsCommand extends Command
 	{
 		private LoggerInterface $logger;
 
+		protected ConfigurationLoaderService $configurationLoaderService;
 		protected PersistenceManager $persistenceManager;
 		protected ApplicationRepository $applicationRepository;
 		protected ApplicationFileService $applicationFileService;
 
-		public function __construct(PersistenceManager     $persistenceManager,
-									ApplicationRepository  $applicationRepository,
-									ApplicationFileService $applicationFileService,
-									LoggerInterface        $logger)
+		public function __construct(ConfigurationLoaderService	$configurationLoaderService,
+									PersistenceManager     		$persistenceManager,
+									ApplicationRepository  		$applicationRepository,
+									ApplicationFileService 		$applicationFileService,
+									LoggerInterface        		$logger)
 		{
+			$this->configurationLoaderService = $configurationLoaderService;
 			$this->persistenceManager = $persistenceManager;
 			$this->applicationRepository = $applicationRepository;
 			$this->applicationFileService = $applicationFileService;
@@ -83,6 +87,14 @@ public function configure()
 		 */
 		public function execute($input, $output): int
 		{
+			/*
+			 *	Issue: 	Repositories currently can't be used in TYPO3 v13 inside commands,
+			 * 			unless the ConfigurationManager is loaded in manually. This function
+			 *			does that for us.
+			 *	Link:	https://forge.typo3.org/issues/105616
+			 */
+			$this->configurationLoaderService->initCliEnvironment();
+
 			$days = $input->getArgument('days') ?? 90;
 			$withStatus = $input->getOption('withStatus') ?? false;
 

Classes/Controller/ApplicationController.php

@@ -35,7 +35,6 @@
 	use ITX\Jobapplications\Event\BeforeApplicationPersisted;
 	use ITX\Jobapplications\PageTitle\JobsPageTitleProvider;
 	use ITX\Jobapplications\Service\ApplicationFileService;
-	use ITX\Jobapplications\Utility\Typo3VersionUtility;
 	use ITX\Jobapplications\Utility\UploadFileUtility;
 	use Psr\Http\Message\ResponseInterface;
 	use Psr\Log\LogLevel;
@@ -46,7 +45,6 @@
     use TYPO3\CMS\Core\Log\LogManager;
 	use TYPO3\CMS\Core\Mail\FluidEmail;
 	use TYPO3\CMS\Core\Mail\Mailer;
-	use TYPO3\CMS\Core\Messaging\FlashMessage;
 	use TYPO3\CMS\Core\Resource\Driver\LocalDriver;
 	use TYPO3\CMS\Core\Resource\Exception\ExistingTargetFileNameException;
 	use TYPO3\CMS\Core\Resource\Exception\ExistingTargetFolderException;
@@ -57,7 +55,8 @@
 	use TYPO3\CMS\Core\Resource\FileInterface;
 	use TYPO3\CMS\Core\Resource\ResourceStorageInterface;
 	use TYPO3\CMS\Core\Resource\StorageRepository;
-	use TYPO3\CMS\Core\Utility\GeneralUtility;
+    use TYPO3\CMS\Core\Type\ContextualFeedbackSeverity;
+    use TYPO3\CMS\Core\Utility\GeneralUtility;
 	use TYPO3\CMS\Core\Utility\MailUtility;
 	use TYPO3\CMS\Core\Utility\MathUtility;
 	use TYPO3\CMS\Extbase\Mvc\Controller\ActionController;
@@ -371,7 +370,7 @@ public function createAction(Application $newApplication, Posting $posting = nul
 			// front end check is already covered, this should only block requests avoiding the frontend
 			if (array_key_exists("messageMaxLength", $this->settings) && (strlen($newApplication->getMessage()) > (int)$this->settings['messageMaxLength']))
 			{
-				$this->addFlashMessage("Message too long", "Rejected", FlashMessage::ERROR);
+				$this->addFlashMessage("Message too long", "Rejected", ContextualFeedbackSeverity::ERROR);
 				$this->redirect("new", "Application", null, ["posting" => $posting]);
 			}
 
@@ -715,13 +714,13 @@ private function buildRelations(int $objectUid, int $fileUid, int $objectPid, st
 			}
 		}
 
-        /**
-         * @param array            $arguments
-         * @param Posting|null     $posting
-         * @param Application|null $newApplication
-         *
+		/**
+		 * @param array            $arguments
+		 * @param Posting|null     $posting
+		 * @param Application|null $newApplication
+		 *
 		 * @return ResponseInterface|null
-         */
+		 */
 		private function checkHoneypot(array $arguments, ?Posting $posting, ?Application $newApplication): ResponseInterface | null
 		{
 			if (($newApplication && ($arguments["new_mail"] ?? '') !== '')) {