Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop cached default date from postings #154

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

mbrodala
Copy link
Contributor

@mbrodala mbrodala commented Sep 2, 2024

TCA is cached, so setting a "default" date is not possible here anymore. The default date would otherwise always be the date from when the TCA cache entry was written.

TCA is cached, so setting a "default" date is not possible here anymore. The default date would otherwise always be the date from when the TCA cache entry was written.
@mbrodala
Copy link
Contributor Author

mbrodala commented Sep 2, 2024

See e.g. georgringer/news@0f27cd8

@benjasper
Copy link
Collaborator

Thanks, but what happens, when there is no default date? Is it not filled out?
I see that Georg Ringer used a hook to set the date, should we do that instead?

@mbrodala
Copy link
Contributor Author

mbrodala commented Sep 3, 2024

Yes, the field is empty by default which would be fine IMO. The date_published field can be filled freely anyways, so the current behavior is mostly a nice-to-have. If it was working, that is. ;-)

This would be different if crdate would be used in the related domain model instead, then this should and would not be editable.

However, I'd question the field altogether since publishing can also happen way after posting creation, e.g. when using Workspaces.

Aside from all this, the not working default dates should be dropped. And yes, this could be implemented anew using a hook like in News, but that should happen separately.

@benjasper
Copy link
Collaborator

Fair points, the field was originally meant to be purely optical, as HR people like to reset the field, to let the posting appear newer ;)

Also people who depend on this being filled out, can always make it required

@benjasper benjasper merged commit 73f5e57 into itx-informationssysteme:main Sep 3, 2024
2 checks passed
@mbrodala mbrodala deleted the patch-1 branch September 3, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants