Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crystal 0.36.0 #1734

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Crystal 0.36.0 #1734

merged 2 commits into from
Feb 2, 2021

Conversation

saltycrys
Copy link
Member

Update code for Crystal 0.36.0

Rename HTTPClient@socket to HTTPClient@io, see crystal-lang/crystal#9543.

Rename URI#full_path to URI#request_target, see crystal-lang/crystal#10099.

Update to Crystal 0.36.0

Crystal versions below 0.36.0 are no longer supported.

@saltycrys saltycrys mentioned this pull request Jan 31, 2021
@TheFrenchGhosty TheFrenchGhosty added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Feb 1, 2021
Copy link
Contributor

@Perflyst Perflyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running for a few hours on one of my nodes, appears to be working as expected.

@TheFrenchGhosty TheFrenchGhosty removed the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Feb 2, 2021
@TheFrenchGhosty
Copy link
Member

@saltycrys Can you fix the conflict? (you can then merge it)

Rename `HTTPClient@socket` to `HTTPClient@io`, see
crystal-lang/crystal#9543.

Rename `URI#full_path` to `URI#request_target`, see
crystal-lang/crystal#10099.
Crystal versions below `0.36.0` are no longer supported.
@github-actions
Copy link

github-actions bot commented Jun 9, 2021

This pull request has been automatically locked since there has not been any activity in it in the last 30 days. If you want to tell us about needed or wanted changes or if problems related to this code are discovered, feel free to open an issue or a new pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants