... even better naming for function ...

ivanilves · Oct 18, 2017 · e255763 · e255763
1 parent 3fb2d17
commit e255763
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/auth/auth.go b/auth/auth.go
@@ -18,7 +18,7 @@ type TokenResponse interface {
 	Method() string
 	Token() string
 	ExpiresIn() int
-	Header() string
+	AuthHeader() string
 }
 
 func parseAuthHeader(headers http.Header) (string, string, error) {

diff --git a/auth/basic/basic.go b/auth/basic/basic.go
@@ -26,8 +26,8 @@ func (tr TokenResponse) ExpiresIn() int {
 	return 0
 }
 
-// Header returns contents of the Authorization HTTP header
-func (tr TokenResponse) Header() string {
+// AuthHeader returns contents of the Authorization HTTP header
+func (tr TokenResponse) AuthHeader() string {
 	return tr.Method() + " " + tr.Token()
 }
 

diff --git a/auth/bearer/bearer.go b/auth/bearer/bearer.go
@@ -28,8 +28,8 @@ func (tr TokenResponse) ExpiresIn() int {
 	return tr.E
 }
 
-// Header returns contents of the Authorization HTTP header
-func (tr TokenResponse) Header() string {
+// AuthHeader returns contents of the Authorization HTTP header
+func (tr TokenResponse) AuthHeader() string {
 	return tr.Method() + " " + tr.Token()
 }
 

diff --git a/auth/none/none.go b/auth/none/none.go
@@ -19,8 +19,8 @@ func (tr TokenResponse) ExpiresIn() int {
 	return 0
 }
 
-// Header returns contents of the Authorization HTTP header
-func (tr TokenResponse) Header() string {
+// AuthHeader returns contents of the Authorization HTTP header
+func (tr TokenResponse) AuthHeader() string {
 	return tr.Method() + " " + tr.Token()
 }
 

diff --git a/main.go b/main.go
@@ -120,7 +120,7 @@ func main() {
 				suicide(err, true)
 			}
 
-			remoteTags, err := remote.FetchTags(registry, repoPath, tr.Header(), concurrentRequests)
+			remoteTags, err := remote.FetchTags(registry, repoPath, tr.AuthHeader(), concurrentRequests)
 			if err != nil {
 				suicide(err, true)
 			}

diff --git a/main_test.go b/main_test.go
@@ -29,7 +29,7 @@ func TestDockerHubWithPublicRepo(t *testing.T) {
 		t.Fatalf("Failed to get DockerHub public repo token: %s", err.Error())
 	}
 
-	tags, err := remote.FetchTags(dockerHub, repo, tr.Header(), 128)
+	tags, err := remote.FetchTags(dockerHub, repo, tr.AuthHeader(), 128)
 	if err != nil {
 		t.Fatalf("Failed to list DockerHub public repo (%s) tags: %s", repo, err.Error())
 	}
@@ -60,7 +60,7 @@ func TestDockerHubWithPrivateRepo(t *testing.T) {
 		t.Fatalf("Failed to get DockerHub private repo token: %s", err.Error())
 	}
 
-	tags, err := remote.FetchTags(dockerHub, repo, tr.Header(), 128)
+	tags, err := remote.FetchTags(dockerHub, repo, tr.AuthHeader(), 128)
 	if err != nil {
 		t.Fatalf("Failed to list DockerHub private repo (%s) tags: %s", repo, err.Error())
 	}