Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/upgradePackages #322

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

evmartinelli
Copy link

@evmartinelli evmartinelli commented Aug 18, 2023

PT-BR

Olá Ivan, tudo bem? Encontrei o seu repo como um das mais estruturados para C# com boas práticas de arquitetura. Ao tentar rodar no OSX encontrei algumas dificuldades que busquei solucionar nesse PR.

  • Atualizar Dockerfiles para .NET 7
  • Ajustar o string connection para evitar erro de certificado
  • Atualizar a versão do Node
  • Fix do create Theme no material-ui

Caso essas alterações façam sentido, fique a vontade para mergear o PR.

Caso não façam e quiser me dar um feedback, será legal também!

No mais, sucesso!!

EN

Hello Ivan, how are you? I found your repository to be one of the most well-structured for C#, with good architectural practices. When trying to run it on OSX, I encountered some difficulties that I tried to address in this PR.

  • Update Dockerfiles for .NET 7
  • Adjust the connection string to avoid certificate errors
  • Update the Node version
  • Fix the create Theme in material-ui

If these changes make sense, feel free to merge the PR.

If they don't and you'd like to provide feedback, that would be great too!

In any case, best of luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant