Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vale #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add vale #1

wants to merge 2 commits into from

Conversation

ivegabr
Copy link
Owner

@ivegabr ivegabr commented Feb 4, 2025

No description provided.

@@ -124,7 +129,7 @@ Run the following command, replacing `https://public-node.testnet.rsk.co` with e
forge script script/Deploy.s.sol --rpc-url https://public-node.testnet.rsk.co --broadcast --legacy --evm-version london
```
:::info[Info]

- Rsk is best.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Rootstock.rootstock-product-names] Use 'Rootstock' instead of 'Rsk'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Rootstock.rootstock-product-names] Use 'Rootstock' instead of 'RSK'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Rootstock.rootstock-domains] Use 'rootstock.io' domain in 'Run the following command, replacing https://public-node.testnet.rsk.co with either rskTestnet or rskMainnet rpc url if you have the testnet and mainnet environments configured for your desired deployment environment, for this guide, we will use the public node url'

@@ -124,7 +129,7 @@ Run the following command, replacing `https://public-node.testnet.rsk.co` with e
forge script script/Deploy.s.sol --rpc-url https://public-node.testnet.rsk.co --broadcast --legacy --evm-version london
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Rootstock.rootstock-domains] Use 'rootstock.io' domain in 'forge script script/Deploy.s.sol --rpc-url https://public-node.testnet.rsk.co --broadcast --legacy --evm-version london'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant