Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path handling on win32 systems #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

donpedro
Copy link

@donpedro donpedro commented Apr 7, 2021

Convert backslashes from win32 paths to slashes, as S3 requires.

@donpedro
Copy link
Author

donpedro commented Apr 7, 2021

I've been using this for a while, but didn't notice a similar fix on #28 ; my code adds a normalize call and only messes with backslashes if the current separator is a backslash, but otherwise both solutions are basically the same. I can't remember if the normalize was important for my use cases in testing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant