Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pure docker workflow #26

Merged
merged 6 commits into from
Jun 28, 2022
Merged

Pure docker workflow #26

merged 6 commits into from
Jun 28, 2022

Conversation

j-blue-arz
Copy link
Owner

  • uses already existing Dockerfiles to lint/test/build/release
  • removes release workflow -> every build will push the images

@j-blue-arz
rewrote github actions workflow with docker build
e3dfcd6 
Combines base and release workflow, because
artifacts of base workflow were unused.
Instead, now always pushes to :latest when build succeeds.

Uses raw docker commands without buildx,
build-push-action only for pushing
@j-blue-arz
fixes backend test inside container
2ad690f 
coverage is broken currently, but not used anyways
@j-blue-arz
fixes release stage by adding checkout
fe99fa2
@j-blue-arz
sets up buildx in each job
cec1b7c 
Currently, docker build in workflows does not respect multistage builds.
Locally, it works correctly and omits unneeded stages.
Supposedly because buildx is not the default builder in workflows.
@j-blue-arz
tries to speed up build by caching image layers
1a29cda
@j-blue-arz
reverts docker cache
7a34098 
it did not speed up the build.
Apparently, it has to be used in combination with build-push-action.
I currently prefer to use raw docker build commands for simplicity.
@j-blue-arz j-blue-arz self-assigned this Jun 28, 2022
@j-blue-arz j-blue-arz merged commit aa630d6 into master Jun 28, 2022
@j-blue-arz j-blue-arz deleted the wip-actions-pure-docker branch June 28, 2022 23:44
@j-blue-arz j-blue-arz restored the wip-actions-pure-docker branch November 25, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@j-blue-arz j-blue-arz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@j-blue-arz