Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#814 added support for descriptions from java interfaces #815

Conversation

Bramaten
Copy link
Contributor

Descriptions are for methods available only at the moment. The approach works well for all property interfaces but the configuration sub-interfaces like analyze and store due to the description being annotated inside them.

@Bramaten Bramaten linked an issue Feb 17, 2025 that may be closed by this pull request
@Bramaten Bramaten requested a review from DirkMahler February 19, 2025 07:38
Copy link
Member

@DirkMahler DirkMahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a test for this.

@DirkMahler DirkMahler merged commit 64499c4 into master Feb 24, 2025
7 checks passed
@DirkMahler DirkMahler deleted the 814-json-schema-generator-should-use-descriptions-from-java-interfaces branch February 24, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON schema generator should use descriptions from Java interfaces
2 participants