Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dbus compatibility for OS X #225

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Added dbus compatibility for OS X #225

wants to merge 26 commits into from

Conversation

claudiocabral
Copy link
Contributor

Changed dbus/controller.c in order to allow jackdbus to be built on OS X.
Don't know it's a feature a lot of people are interested in, but would like to share it anyways

@adiknoth
Copy link
Member

I've rebased a copy of this patch against current master. Please do as well (git rebase master) to discuss the actual diff.

@adiknoth adiknoth self-assigned this Mar 12, 2017
@gaming-hacker
Copy link

gaming-hacker commented Mar 13, 2017

yeah, i had to go and find a copy of that aften lib and hack it to get it to build on osx. i rebased to the lastest and still get weird errors linking to that aften lib. does this require 32-bit version or 64-bit libs?

jack2/build/svnversion.h (0+2d1d323505585d406a7e64fb932953baefc5945e)

/common/JackAC3Encoder.cpp:129:23: error: no matching function for call to 'aften_encode_frame'
 aften_encode_frame(&fAftenContext, fAC3Buffer + SPDIF_HEADER_SIZE, fSampleBuffer)

'coreaudio' failed (exit status 1): 
	{task 4349866832: cxx JackAC3Encoder.cpp -> JackAC3Encoder.cpp.8.o}

@7890 7890 added OSX Bug or feature related to using JACK on OSX dbus DBus related labels Jan 14, 2019
@7890
Copy link
Contributor

7890 commented Feb 9, 2019

@claudiocabral Hi, if you make a small change to the pull request it will flow through the travis build system so we can see if there are any issues. The travis build was introduced after this PR was made.
Something like

git commit -a --allow-empty-message -m ''

should do the trick. Thanks

@claudiocabral
Copy link
Contributor Author

Hi,
Haven't looked into this code for well, 3 years, and I no longer have an OS X machine
Just did some commiting (added and removed a line from README), hope that's enough to get it going

@7890
Copy link
Contributor

7890 commented Feb 13, 2019

It seems it didn't work, I can't see a commit either (?).

@claudiocabral
Copy link
Contributor Author

wait, my bad. I totally forgot to checkout the correct branch after cloning... will redo it

@7890
Copy link
Contributor

7890 commented Feb 13, 2019

Fantastic, seems to do something now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbus DBus related needs review OSX Bug or feature related to using JACK on OSX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants