Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various windows build issues #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

e9925248
Copy link
Contributor

No description provided.

@mseeber
Copy link
Contributor

mseeber commented Dec 25, 2014

Would it bring any improvement to read the target platform (32 or 64 bit) from env['DEST_CPU'] instead of running the compiler and checking for the macro?

@e9925248
Copy link
Contributor Author

The current check is aligned with with the DLL name selection of the Jack code.

Considering 32+64 bit x86 only, checking DEST_CPU should work with GCC (Mingw) and Intel Compilers. I can't spot any DEST_CPU support with other compiler in waf - nor any 32/64 bit distinction via DEST_CPU for non Intel architectures.

In the long term, in my option, the hardcoded filenames in the code should go away and the build system should inject the generated library names.

@mseeber
Copy link
Contributor

mseeber commented Dec 26, 2014

Ah, ok, I'm just not that familiar with waf, that's why I asked.

@karllinden
Copy link
Contributor

I think you will have to redo the PortAudio-fix commit since the build system has changed since you opened this PR. But otherwise the PortAudio-fix looks correct.

@adiknoth
Copy link
Member

If you still care about this PR, please update to current master and then ping the thread, so that we can merge shortly after.

@adiknoth adiknoth self-assigned this Mar 12, 2017
@7890 7890 added Windows Bug or feature related to using JACK on Windows build un/install Related to building releases on several platforms labels Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build un/install Related to building releases on several platforms merge conflict Windows Bug or feature related to using JACK on Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants