Add MaxConnLifetime config setting to pool in v3 #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in light of the issue we are experiencing with jackc#845, and the fact that we want to have the ability to recycle our connections, this patch adds the MaxConnLifetime config value and its behaviour to v3 releases. The work done in this PR is trying to mimic what has done for v4 track: jackc@c604afb The only difference is that this one doesn't have a default maxConnLifetime value defined, which means that the current v3 usage out there shouldn't be impacted by this change.
|
@jackc 👋 is there a way to kick off the CI server to run the tests for |
tugberkugurlu
changed the title
|
I restarted the CI but it timed out. I ran the tests locally and something seems to hang there as well. I don't see the reason why but it appears that it is hanging in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our usage, we want to enforce our connections to be recycled so that the application can pick up the newly added replicas in ur aurora cluster.
In light of the issue we are experiencing with #845,
and the fact that we want to have the ability to recycle our connections,
this patch proposes to add the
MaxConnLifetimeconfig value and its behaviour to v3 releases.The work done in this PR is trying to mimic what has done for v4 track, but w/o the idle connection check since that has turned out be an harder port than the simple implementation of just checking the conn lifetime after its usage during
Releasephase: c604afbThe the other difference is that this one doesn't have a default maxConnLifetime value defined,
which means that the current v3 usage out there shouldn't be impacted by this change.