Fix Ruby 2.7 keyword parameters deprecation warning #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`has_many` takes keyword-arguments. > warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
CloCkWeRX
approved these changes
May 8, 2021
|
@jackdempsey - would you be ok granting other contributors merge rights; or release rights for this gem? I know for example, fat_free_crm makes use of this and would be happy to take over the maintenance or do an updated/renamed fork. |
aschurg
added a commit
to AdvancedEnergyEconomy/acts_as_commentable
that referenced
this pull request
Jul 28, 2022
code taken from this unmerged pull request: jackdempsey#76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following warnings that are printed when using this gem with Ruby 2.7.: