Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger] make curl image configurable #630

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FieteO
Copy link
Contributor

@FieteO FieteO commented Feb 3, 2025

What this PR does

This PR makes the curl image that is used for elasticsearch configurable and changes it to not use a latest tag:

helm template --set provisionDataStore.elasticsearch=true . | grep curlimages
          image: curlimages/curl:8.11.1
          image: curlimages/curl:8.11.1

The tag is configurable via

images:
  curl: "curlimages/curl:8.11.1"

I am not sure that is the best location in the values.yaml file. I am open for suggestions.

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

@FieteO FieteO force-pushed the make-curl-image-configurable branch from a2ec284 to 55ab6b0 Compare February 3, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant