Skip to content

Commit

Permalink
Remove defaultProps from Ticks.tsx (#2617)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Part of #2596 

## Description of the changes
- 

## How was this change tested?
- 

## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: cs-308-2023 <[email protected]>
  • Loading branch information
ADI-ROXX authored Jan 25, 2025
1 parent c0f156b commit 57f5648
Showing 1 changed file with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ type TicksProps = {
startTime?: number | TNil;
};

export default function Ticks(props: TicksProps) {
const { endTime, numTicks, showLabels, startTime } = props;

export default function Ticks({ endTime = null, numTicks, showLabels = null, startTime = null }: TicksProps) {
let labels: undefined | string[];
if (showLabels) {
labels = [];
Expand Down Expand Up @@ -57,9 +55,3 @@ export default function Ticks(props: TicksProps) {
}
return <div className="Ticks">{ticks}</div>;
}

Ticks.defaultProps = {
endTime: null,
showLabels: null,
startTime: null,
};

0 comments on commit 57f5648

Please sign in to comment.