Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defaultProps from KeyValuesText.tsx #2614

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ADI-ROXX
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

@ADI-ROXX ADI-ROXX requested a review from a team as a code owner January 24, 2025 04:38
@ADI-ROXX ADI-ROXX requested review from mahadzaryab1 and removed request for a team January 24, 2025 04:38
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.60%. Comparing base (2d880b4) to head (79eb890).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
.../TraceTimelineViewer/SpanDetail/KeyValuesTable.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2614      +/-   ##
==========================================
- Coverage   96.61%   96.60%   -0.02%     
==========================================
  Files         255      255              
  Lines        7738     7738              
  Branches     1988     1989       +1     
==========================================
- Hits         7476     7475       -1     
- Misses        262      263       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ADI-ROXX
Copy link
Contributor Author

@yurishkuro How to solve the following issue:
image

@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Jan 25, 2025
@yurishkuro
Copy link
Member

can we improve code coverage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants