Add Unit Tests For New Factory Method

Signed-off-by: Mahad Zaryab <[email protected]>

cmd/jaeger/internal/extension/jaegerstorage/factoryadapter/factory_test.go

@@ -36,15 +36,22 @@ func TestAdapterClose(t *testing.T) {
 	require.NoError(t, f.Close(context.Background()))
 }
 
-func TestAdapterCreateTraceReader(t *testing.T) {
-	defer func() {
-		if r := recover(); r == nil {
-			t.Errorf("create trace reader did not panic")
-		}
-	}()
+func TestAdapter_CreateTraceReader_Error(t *testing.T) {
+	f1 := new(factoryMocks.Factory)
+	f1.On("CreateSpanReader").Return(nil, errors.New("mock error"))
 
-	f := &Factory{}
-	f.CreateTraceReader()
+	f := NewFactory(f1)
+	_, err := f.CreateTraceReader()
+	require.ErrorContains(t, err, "mock error")
+}
+
+func TestAdapter_CreateTraceReader_NoError(t *testing.T) {
+	f1 := new(factoryMocks.Factory)
+	f1.On("CreateSpanReader").Return(new(spanstoreMocks.Reader), nil)
+
+	f := NewFactory(f1)
+	_, err := f.CreateTraceReader()
+	require.NoError(t, err)
 }
 
 func TestAdapterCreateTraceWriterError(t *testing.T) {