Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
yurishkuro committed Jul 12, 2024
1 parent a5c5654 commit 09c2638
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/jaeger/internal/extension/jaegerquery/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ func TestServerStart(t *testing.T) {
err := server.Start(context.Background(), host)
if tt.expectedErr == "" {
require.NoError(t, err)
defer server.Shutdown(context.Background())
// We need to wait for servers to become available.
// Otherwise, we could call shutdown before the servers are even started,
// which could cause flaky code coverage by going through error cases.
Expand All @@ -194,7 +195,6 @@ func TestServerStart(t *testing.T) {
"grpc.health.v1.Health",
},
}.Execute(t)
defer server.Shutdown(context.Background())
} else {
require.ErrorContains(t, err, tt.expectedErr)
}
Expand Down

0 comments on commit 09c2638

Please sign in to comment.