Skip to content

Commit

Permalink
Bump the otel-instrumentation group with 2 updates (#4944)
Browse files Browse the repository at this point in the history 
Bumps the otel-instrumentation group with 2 updates:
[go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib)
and
[go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp](https://github.com/open-telemetry/opentelemetry-go-contrib).

Updates
`go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`
from 0.45.0 to 0.46.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/releases">go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc's
releases</a>.</em></p>
<blockquote>
<h2>Release v1.21.0/v0.46.0/v0.15.0/v0.1.0</h2>
<h3>Added</h3>
<ul>
<li>Add the new <code>go.opentelemetry.io/contrib/instrgen</code>
package to provide auto-generated source code instrumentation. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/3068">#3068</a>,
<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/3108">#3108</a>)</li>
<li>Add
<code>&quot;go.opentelemetry.io/contrib/samplers/jaegerremote&quot;.WithSamplingStrategyFetcher</code>
which sets custom fetcher implementation. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4045">#4045</a>)</li>
<li>Add <code>&quot;go.opentelemetry.io/contrib/config&quot;</code>
package that includes configuration models generated via go-jsonschema.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4376">#4376</a>)</li>
<li>Add <code>NewSDK</code> function to
<code>&quot;go.opentelemetry.io/contrib/config&quot;</code>. The initial
implementation only returns noop providers. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4414">#4414</a>)</li>
<li>Add metrics support (No-op, OTLP and Prometheus) to
<code>go.opentelemetry.io/contrib/exporters/autoexport</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4229">#4229</a>,
<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4479">#4479</a>)</li>
<li>Add support for <code>console</code> span exporter and metrics
exporter in
<code>go.opentelemetry.io/contrib/exporters/autoexport</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4486">#4486</a>)</li>
<li>Set unit and description on all instruments in
<code>go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4500">#4500</a>)</li>
<li>Add metric support for <code>grpc.StatsHandler</code> in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4356">#4356</a>)</li>
<li>Expose the name of the scopes in all instrumentation libraries as
<code>ScopeName</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4448">#4448</a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>Dropped compatibility testing for [Go 1.19].
The project no longer guarantees support for this version of Go. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4352">#4352</a>)</li>
<li>Upgrade dependencies of OpenTelemetry Go to use the new <a
href="https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.20.0"><code>v1.20.0</code>/<code>v0.43.0</code>
release</a>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4546">#4546</a>)</li>
<li>In <code>go.opentelemetry.io/contrib/exporters/autoexport</code>,
<code>Option</code> was renamed to <code>SpanOption</code>. The old name
is deprecated but continues to be supported as an alias. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4229">#4229</a>)</li>
</ul>
<h3>Deprecated</h3>
<ul>
<li>The interceptors (<code>UnaryClientInterceptor</code>,
<code>StreamClientInterceptor</code>,
<code>UnaryServerInterceptor</code>,
<code>StreamServerInterceptor</code>,
<code>WithInterceptorFilter</code>) are deprecated. Use stats handlers
(<code>NewClientHandler</code>, <code>NewServerHandler</code>) instead.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4534">#4534</a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>The <code>go.opentelemetry.io/contrib/samplers/jaegerremote</code>
sampler does not panic when the default HTTP round-tripper
(<code>http.DefaultTransport</code>) is not
<code>*http.Transport</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4045">#4045</a>)</li>
<li>The <code>UnaryServerInterceptor</code> in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>
now sets gRPC status code correctly for the
<code>rpc.server.duration</code> metric. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4481">#4481</a>)</li>
<li>The <code>NewClientHandler</code>, <code>NewServerHandler</code> in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>
now honor <code>otelgrpc.WithMessageEvents</code> options. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4536">#4536</a>)</li>
</ul>
<h2>Release v1.20.0/v0.45.0/v0.14.0</h2>
<h3>Added</h3>
<ul>
<li>Set the description for the <code>rpc.server.duration</code> metric
in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4302">#4302</a>)</li>
<li>Add <code>NewServerHandler</code> and <code>NewClientHandler</code>
that return a <code>grpc.StatsHandler</code> used for gRPC
instrumentation in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/3002">#3002</a>)</li>
<li>Add new Prometheus bridge module in
<code>go.opentelemetry.io/contrib/bridges/prometheus</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4227">#4227</a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>Upgrade dependencies of OpenTelemetry Go to use the new <a
href="https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.19.0"><code>v1.19.0</code>/<code>v0.42.0</code>/<code>v0.0.7</code>
release</a>.</li>
<li>Use <code>grpc.StatsHandler</code> for gRPC instrumentation in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/example</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4325">#4325</a>)</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/puckpuck"><code>@​puckpuck</code></a>
made their first contribution in <a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/pull/4302">open-telemetry/opentelemetry-go-contrib#4302</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/compare/v1.19.0...v1.20.0">https://github.com/open-telemetry/opentelemetry-go-contrib/compare/v1.19.0...v1.20.0</a></p>
<h2>Release v1.19.0/v0.44.0/v0.13.0</h2>
<h3>Added</h3>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md">go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc's
changelog</a>.</em></p>
<blockquote>
<h2>[1.21.0/0.46.0/0.15.0/0.1.0] - 2023-11-10</h2>
<h3>Added</h3>
<ul>
<li>Add
<code>&quot;go.opentelemetry.io/contrib/samplers/jaegerremote&quot;.WithSamplingStrategyFetcher</code>
which sets custom fetcher implementation. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4045">#4045</a>)</li>
<li>Add <code>&quot;go.opentelemetry.io/contrib/config&quot;</code>
package that includes configuration models generated via go-jsonschema.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4376">#4376</a>)</li>
<li>Add <code>NewSDK</code> function to
<code>&quot;go.opentelemetry.io/contrib/config&quot;</code>. The initial
implementation only returns noop providers. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4414">#4414</a>)</li>
<li>Add metrics support (No-op, OTLP and Prometheus) to
<code>go.opentelemetry.io/contrib/exporters/autoexport</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4229">#4229</a>,
<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4479">#4479</a>)</li>
<li>Add support for <code>console</code> span exporter and metrics
exporter in
<code>go.opentelemetry.io/contrib/exporters/autoexport</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4486">#4486</a>)</li>
<li>Set unit and description on all instruments in
<code>go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4500">#4500</a>)</li>
<li>Add metric support for <code>grpc.StatsHandler</code> in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4356">#4356</a>)</li>
<li>Expose the name of the scopes in all instrumentation libraries as
<code>ScopeName</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4448">#4448</a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>Dropped compatibility testing for [Go 1.19].
The project no longer guarantees support for this version of Go. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4352">#4352</a>)</li>
<li>Upgrade dependencies of OpenTelemetry Go to use the new <a
href="https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.20.0"><code>v1.20.0</code>/<code>v0.43.0</code>
release</a>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4546">#4546</a>)</li>
<li>In <code>go.opentelemetry.io/contrib/exporters/autoexport</code>,
<code>Option</code> was renamed to <code>SpanOption</code>. The old name
is deprecated but continues to be supported as an alias. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4229">#4229</a>)</li>
</ul>
<h3>Deprecated</h3>
<ul>
<li>The interceptors (<code>UnaryClientInterceptor</code>,
<code>StreamClientInterceptor</code>,
<code>UnaryServerInterceptor</code>,
<code>StreamServerInterceptor</code>,
<code>WithInterceptorFilter</code>) are deprecated. Use stats handlers
(<code>NewClientHandler</code>, <code>NewServerHandler</code>) instead.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4534">#4534</a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>The <code>go.opentelemetry.io/contrib/samplers/jaegerremote</code>
sampler does not panic when the default HTTP round-tripper
(<code>http.DefaultTransport</code>) is not
<code>*http.Transport</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4045">#4045</a>)</li>
<li>The <code>UnaryServerInterceptor</code> in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>
now sets gRPC status code correctly for the
<code>rpc.server.duration</code> metric. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4481">#4481</a>)</li>
<li>The <code>NewClientHandler</code>, <code>NewServerHandler</code> in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>
now honor <code>otelgrpc.WithMessageEvents</code> options. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4536">#4536</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/b4b06bcdc72f96690d319705c72840c7198108e6"><code>b4b06bc</code></a>
Release v1.21.0/v0.46.0/v0.15.0/v0.1.0 (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4546">#4546</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/c1ac3039d0bb7cdf83630210f8209b7d0b95cd48"><code>c1ac303</code></a>
config: Prepare module for release (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4541">#4541</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/fe68fe96a73a70a27afad0772618d7b15b3aa124"><code>fe68fe9</code></a>
host: fix typo (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4540">#4540</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/016b46fd3137a9c72bd581de86949dafa119e983"><code>016b46f</code></a>
otelgrpc: Use net.Listen in TestStatsHandler (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4538">#4538</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/23bd4ed41fe30ae1e9a5b11b57e902743f94490b"><code>23bd4ed</code></a>
otelgrpc: Deprecate interceptors in favor of stats handlers (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4534">#4534</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/a3b16ae7ecdc805995842e4d2289cd064396dd46"><code>a3b16ae</code></a>
Expose instrumentation scope name (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4448">#4448</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/2b690297abce4af6d342091ab76f7191e000f4f0"><code>2b69029</code></a>
otelgrpc: Fix stats handlers to honor WithMessageEvents option (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4536">#4536</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/f6aeb0d909e933a7e8bf416aab1c9f0277c8aed6"><code>f6aeb0d</code></a>
otelgrpc: Stablize TestInterceptors (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4535">#4535</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/b44dfc9092b157625a5815cb437583cee663333b"><code>b44dfc9</code></a>
otelgrpc: Remove high cardinality metric attributes (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4322">#4322</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/2a5fe23f9705a1fa94781ccbef055c3746f7ae3d"><code>2a5fe23</code></a>
otelgrpc: Refine tests to use a net socket instead of a buffer (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4503">#4503</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/compare/zpages/v0.45.0...zpages/v0.46.0">compare
view</a></li>
</ul>
</details>
<br />

Updates `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp`
from 0.45.0 to 0.46.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/releases">go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp's
releases</a>.</em></p>
<blockquote>
<h2>Release v1.21.0/v0.46.0/v0.15.0/v0.1.0</h2>
<h3>Added</h3>
<ul>
<li>Add the new <code>go.opentelemetry.io/contrib/instrgen</code>
package to provide auto-generated source code instrumentation. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/3068">#3068</a>,
<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/3108">#3108</a>)</li>
<li>Add
<code>&quot;go.opentelemetry.io/contrib/samplers/jaegerremote&quot;.WithSamplingStrategyFetcher</code>
which sets custom fetcher implementation. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4045">#4045</a>)</li>
<li>Add <code>&quot;go.opentelemetry.io/contrib/config&quot;</code>
package that includes configuration models generated via go-jsonschema.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4376">#4376</a>)</li>
<li>Add <code>NewSDK</code> function to
<code>&quot;go.opentelemetry.io/contrib/config&quot;</code>. The initial
implementation only returns noop providers. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4414">#4414</a>)</li>
<li>Add metrics support (No-op, OTLP and Prometheus) to
<code>go.opentelemetry.io/contrib/exporters/autoexport</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4229">#4229</a>,
<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4479">#4479</a>)</li>
<li>Add support for <code>console</code> span exporter and metrics
exporter in
<code>go.opentelemetry.io/contrib/exporters/autoexport</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4486">#4486</a>)</li>
<li>Set unit and description on all instruments in
<code>go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4500">#4500</a>)</li>
<li>Add metric support for <code>grpc.StatsHandler</code> in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4356">#4356</a>)</li>
<li>Expose the name of the scopes in all instrumentation libraries as
<code>ScopeName</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4448">#4448</a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>Dropped compatibility testing for [Go 1.19].
The project no longer guarantees support for this version of Go. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4352">#4352</a>)</li>
<li>Upgrade dependencies of OpenTelemetry Go to use the new <a
href="https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.20.0"><code>v1.20.0</code>/<code>v0.43.0</code>
release</a>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4546">#4546</a>)</li>
<li>In <code>go.opentelemetry.io/contrib/exporters/autoexport</code>,
<code>Option</code> was renamed to <code>SpanOption</code>. The old name
is deprecated but continues to be supported as an alias. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4229">#4229</a>)</li>
</ul>
<h3>Deprecated</h3>
<ul>
<li>The interceptors (<code>UnaryClientInterceptor</code>,
<code>StreamClientInterceptor</code>,
<code>UnaryServerInterceptor</code>,
<code>StreamServerInterceptor</code>,
<code>WithInterceptorFilter</code>) are deprecated. Use stats handlers
(<code>NewClientHandler</code>, <code>NewServerHandler</code>) instead.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4534">#4534</a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>The <code>go.opentelemetry.io/contrib/samplers/jaegerremote</code>
sampler does not panic when the default HTTP round-tripper
(<code>http.DefaultTransport</code>) is not
<code>*http.Transport</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4045">#4045</a>)</li>
<li>The <code>UnaryServerInterceptor</code> in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>
now sets gRPC status code correctly for the
<code>rpc.server.duration</code> metric. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4481">#4481</a>)</li>
<li>The <code>NewClientHandler</code>, <code>NewServerHandler</code> in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>
now honor <code>otelgrpc.WithMessageEvents</code> options. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4536">#4536</a>)</li>
</ul>
<h2>Release v1.20.0/v0.45.0/v0.14.0</h2>
<h3>Added</h3>
<ul>
<li>Set the description for the <code>rpc.server.duration</code> metric
in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4302">#4302</a>)</li>
<li>Add <code>NewServerHandler</code> and <code>NewClientHandler</code>
that return a <code>grpc.StatsHandler</code> used for gRPC
instrumentation in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/3002">#3002</a>)</li>
<li>Add new Prometheus bridge module in
<code>go.opentelemetry.io/contrib/bridges/prometheus</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4227">#4227</a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>Upgrade dependencies of OpenTelemetry Go to use the new <a
href="https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.19.0"><code>v1.19.0</code>/<code>v0.42.0</code>/<code>v0.0.7</code>
release</a>.</li>
<li>Use <code>grpc.StatsHandler</code> for gRPC instrumentation in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/example</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4325">#4325</a>)</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/puckpuck"><code>@​puckpuck</code></a>
made their first contribution in <a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/pull/4302">open-telemetry/opentelemetry-go-contrib#4302</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/compare/v1.19.0...v1.20.0">https://github.com/open-telemetry/opentelemetry-go-contrib/compare/v1.19.0...v1.20.0</a></p>
<h2>Release v1.19.0/v0.44.0/v0.13.0</h2>
<h3>Added</h3>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md">go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp's
changelog</a>.</em></p>
<blockquote>
<h2>[1.21.0/0.46.0/0.15.0/0.1.0] - 2023-11-10</h2>
<h3>Added</h3>
<ul>
<li>Add
<code>&quot;go.opentelemetry.io/contrib/samplers/jaegerremote&quot;.WithSamplingStrategyFetcher</code>
which sets custom fetcher implementation. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4045">#4045</a>)</li>
<li>Add <code>&quot;go.opentelemetry.io/contrib/config&quot;</code>
package that includes configuration models generated via go-jsonschema.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4376">#4376</a>)</li>
<li>Add <code>NewSDK</code> function to
<code>&quot;go.opentelemetry.io/contrib/config&quot;</code>. The initial
implementation only returns noop providers. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4414">#4414</a>)</li>
<li>Add metrics support (No-op, OTLP and Prometheus) to
<code>go.opentelemetry.io/contrib/exporters/autoexport</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4229">#4229</a>,
<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4479">#4479</a>)</li>
<li>Add support for <code>console</code> span exporter and metrics
exporter in
<code>go.opentelemetry.io/contrib/exporters/autoexport</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4486">#4486</a>)</li>
<li>Set unit and description on all instruments in
<code>go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4500">#4500</a>)</li>
<li>Add metric support for <code>grpc.StatsHandler</code> in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4356">#4356</a>)</li>
<li>Expose the name of the scopes in all instrumentation libraries as
<code>ScopeName</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4448">#4448</a>)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>Dropped compatibility testing for [Go 1.19].
The project no longer guarantees support for this version of Go. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4352">#4352</a>)</li>
<li>Upgrade dependencies of OpenTelemetry Go to use the new <a
href="https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.20.0"><code>v1.20.0</code>/<code>v0.43.0</code>
release</a>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4546">#4546</a>)</li>
<li>In <code>go.opentelemetry.io/contrib/exporters/autoexport</code>,
<code>Option</code> was renamed to <code>SpanOption</code>. The old name
is deprecated but continues to be supported as an alias. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4229">#4229</a>)</li>
</ul>
<h3>Deprecated</h3>
<ul>
<li>The interceptors (<code>UnaryClientInterceptor</code>,
<code>StreamClientInterceptor</code>,
<code>UnaryServerInterceptor</code>,
<code>StreamServerInterceptor</code>,
<code>WithInterceptorFilter</code>) are deprecated. Use stats handlers
(<code>NewClientHandler</code>, <code>NewServerHandler</code>) instead.
(<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4534">#4534</a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>The <code>go.opentelemetry.io/contrib/samplers/jaegerremote</code>
sampler does not panic when the default HTTP round-tripper
(<code>http.DefaultTransport</code>) is not
<code>*http.Transport</code>. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4045">#4045</a>)</li>
<li>The <code>UnaryServerInterceptor</code> in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>
now sets gRPC status code correctly for the
<code>rpc.server.duration</code> metric. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4481">#4481</a>)</li>
<li>The <code>NewClientHandler</code>, <code>NewServerHandler</code> in
<code>go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc</code>
now honor <code>otelgrpc.WithMessageEvents</code> options. (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4536">#4536</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/b4b06bcdc72f96690d319705c72840c7198108e6"><code>b4b06bc</code></a>
Release v1.21.0/v0.46.0/v0.15.0/v0.1.0 (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4546">#4546</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/c1ac3039d0bb7cdf83630210f8209b7d0b95cd48"><code>c1ac303</code></a>
config: Prepare module for release (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4541">#4541</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/fe68fe96a73a70a27afad0772618d7b15b3aa124"><code>fe68fe9</code></a>
host: fix typo (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4540">#4540</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/016b46fd3137a9c72bd581de86949dafa119e983"><code>016b46f</code></a>
otelgrpc: Use net.Listen in TestStatsHandler (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4538">#4538</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/23bd4ed41fe30ae1e9a5b11b57e902743f94490b"><code>23bd4ed</code></a>
otelgrpc: Deprecate interceptors in favor of stats handlers (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4534">#4534</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/a3b16ae7ecdc805995842e4d2289cd064396dd46"><code>a3b16ae</code></a>
Expose instrumentation scope name (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4448">#4448</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/2b690297abce4af6d342091ab76f7191e000f4f0"><code>2b69029</code></a>
otelgrpc: Fix stats handlers to honor WithMessageEvents option (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4536">#4536</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/f6aeb0d909e933a7e8bf416aab1c9f0277c8aed6"><code>f6aeb0d</code></a>
otelgrpc: Stablize TestInterceptors (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4535">#4535</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/b44dfc9092b157625a5815cb437583cee663333b"><code>b44dfc9</code></a>
otelgrpc: Remove high cardinality metric attributes (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4322">#4322</a>)</li>
<li><a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/commit/2a5fe23f9705a1fa94781ccbef055c3746f7ae3d"><code>2a5fe23</code></a>
otelgrpc: Refine tests to use a net socket instead of a buffer (<a
href="https://redirect.github.com/open-telemetry/opentelemetry-go-contrib/issues/4503">#4503</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/open-telemetry/opentelemetry-go-contrib/compare/zpages/v0.45.0...zpages/v0.46.0">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
  • Loading branch information
@dependabot @yurishkuro
3 people authored Nov 13, 2023
1 parent cb25bf5 commit 3acbdcd
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 26 deletions.
9 changes: 4 additions & 5 deletions examples/hotrod/services/driver/client.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,10 @@ type Client struct {

// NewClient creates a new driver.Client
func NewClient(tracerProvider trace.TracerProvider, logger log.Factory, hostPort string) *Client {
conn, err := grpc.Dial(hostPort, grpc.WithTransportCredentials(insecure.NewCredentials()),
grpc.WithUnaryInterceptor(
otelgrpc.UnaryClientInterceptor(otelgrpc.WithTracerProvider(tracerProvider))),
grpc.WithStreamInterceptor(
otelgrpc.StreamClientInterceptor(otelgrpc.WithTracerProvider(tracerProvider))))
conn, err := grpc.Dial(hostPort,
grpc.WithTransportCredentials(insecure.NewCredentials()),
grpc.WithStatsHandler(otelgrpc.NewClientHandler(otelgrpc.WithTracerProvider(tracerProvider))),
)
if err != nil {
logger.Bg().Fatal("Cannot create gRPC connection", zap.Error(err))
}
Expand Down
3 changes: 1 addition & 2 deletions examples/hotrod/services/driver/server.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ var _ DriverServiceServer = (*Server)(nil)
func NewServer(hostPort string, otelExporter string, metricsFactory metrics.Factory, logger log.Factory) *Server {
tracerProvider := tracing.InitOTEL("driver", otelExporter, metricsFactory, logger)
server := grpc.NewServer(
grpc.UnaryInterceptor(otelgrpc.UnaryServerInterceptor(otelgrpc.WithTracerProvider(tracerProvider))),
grpc.StreamInterceptor(otelgrpc.StreamServerInterceptor(otelgrpc.WithTracerProvider(tracerProvider))),
grpc.StatsHandler(otelgrpc.NewServerHandler(otelgrpc.WithTracerProvider(tracerProvider))),
)
return &Server{
hostPort: hostPort,
Expand Down
3 changes: 1 addition & 2 deletions examples/memstore-plugin/main.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ func main() {
}
grpc.ServeWithGRPCServer(service, func(options []googleGRPC.ServerOption) *googleGRPC.Server {
return plugin.DefaultGRPCServer([]googleGRPC.ServerOption{
googleGRPC.UnaryInterceptor(otelgrpc.UnaryServerInterceptor(otelgrpc.WithTracerProvider(tracer.OTEL))),
googleGRPC.StreamInterceptor(otelgrpc.StreamServerInterceptor(otelgrpc.WithTracerProvider(tracer.OTEL))),
googleGRPC.StatsHandler(otelgrpc.NewServerHandler(otelgrpc.WithTracerProvider(tracer.OTEL))),
})
})
}
6 changes: 3 additions & 3 deletions go.mod
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ require (
go.opentelemetry.io/collector/receiver v0.88.0
go.opentelemetry.io/collector/receiver/otlpreceiver v0.88.0
go.opentelemetry.io/collector/service v0.88.1-0.20231102040825-2e44da36e2c6
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.45.0
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.45.0
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.46.0
go.opentelemetry.io/otel v1.20.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.20.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.20.0
Expand Down Expand Up @@ -110,7 +110,7 @@ require (
github.com/eapache/go-xerial-snappy v0.0.0-20230731223053-c322873962e3 // indirect
github.com/eapache/queue v1.1.0 // indirect
github.com/fatih/color v1.14.1 // indirect
github.com/felixge/httpsnoop v1.0.3 // indirect
github.com/felixge/httpsnoop v1.0.4 // indirect
github.com/go-kit/log v0.2.1 // indirect
github.com/go-logfmt/logfmt v0.5.1 // indirect
github.com/go-logr/logr v1.3.0 // indirect
Expand Down
12 changes: 6 additions & 6 deletions go.sum
View file
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ github.com/fatih/color v1.13.0/go.mod h1:kLAiJbzzSOZDVNGyDpeOxJ47H46qBXwg5ILebYF
github.com/fatih/color v1.14.1 h1:qfhVLaG5s+nCROl1zJsZRxFeYrHLqWroPOQ8BWiNb4w=
github.com/fatih/color v1.14.1/go.mod h1:2oHN61fhTpgcxD3TSWCgKDiH1+x4OiDVVGH8WlgGZGg=
github.com/felixge/httpsnoop v1.0.1/go.mod h1:m8KPJKqk1gH5J9DgRY2ASl2lWCfGKXixSwevea8zH2U=
github.com/felixge/httpsnoop v1.0.3 h1:s/nj+GCswXYzN5v2DpNMuMQYe+0DDwt5WVCU6CWBdXk=
github.com/felixge/httpsnoop v1.0.3/go.mod h1:m8KPJKqk1gH5J9DgRY2ASl2lWCfGKXixSwevea8zH2U=
github.com/felixge/httpsnoop v1.0.4 h1:NFTV2Zj1bL4mc9sqWACXbQFVBBg2W3GPvqp8/ESS2Wg=
github.com/felixge/httpsnoop v1.0.4/go.mod h1:m8KPJKqk1gH5J9DgRY2ASl2lWCfGKXixSwevea8zH2U=
github.com/fogleman/gg v1.2.1-0.20190220221249-0403632d5b90/go.mod h1:R/bRT+9gY/C5z7JzPU0zXsXHKM4/ayA+zqcVNZzPa1k=
github.com/fortytw2/leaktest v1.3.0 h1:u8491cBMTQ8ft8aeV+adlcytMZylmA5nnwwkRZjI8vw=
github.com/fortytw2/leaktest v1.3.0/go.mod h1:jDsjWgpAGjm2CA7WthBh/CdZYEPF31XHquHwclZch5g=
Expand Down Expand Up @@ -770,10 +770,10 @@ go.opentelemetry.io/collector/semconv v0.88.0 h1:8TVP4hYaUC87S6CCLKNoSxsUE0ChldE
go.opentelemetry.io/collector/semconv v0.88.0/go.mod h1:j/8THcqVxFna1FpvA2zYIsUperEtOaRaqoLYIN4doWw=
go.opentelemetry.io/collector/service v0.88.1-0.20231102040825-2e44da36e2c6 h1:bgsioa6MiPW8uGTjxLLHGlAOHcyghNCqI/aKSDrCZQk=
go.opentelemetry.io/collector/service v0.88.1-0.20231102040825-2e44da36e2c6/go.mod h1:p8cjrpe1YYkQhH0dl4c+ZDKTUqRRfWYqghmfn31OR88=
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.45.0 h1:RsQi0qJ2imFfCvZabqzM9cNXBG8k6gXMv1A0cXRmH6A=
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.45.0/go.mod h1:vsh3ySueQCiKPxFLvjWC4Z135gIa34TQ/NSqkDTZYUM=
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.45.0 h1:x8Z78aZx8cOF0+Kkazoc7lwUNMGy0LrzEMxTm4BbTxg=
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.45.0/go.mod h1:62CPTSry9QZtOaSsE3tOzhx6LzDhHnXJ6xHeMNNiM6Q=
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0 h1:PzIubN4/sjByhDRHLviCjJuweBXWFZWhghjg7cS28+M=
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0/go.mod h1:Ct6zzQEuGK3WpJs2n4dn+wfJYzd/+hNnxMRTWjGn30M=
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.46.0 h1:1eHu3/pUSWaOgltNK3WJFaywKsTIr/PwvHyDmi0lQA0=
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.46.0/go.mod h1:HyABWq60Uy1kjJSa2BVOxUVao8Cdick5AWSKPutqy6U=
go.opentelemetry.io/contrib/propagators/b3 v1.20.0 h1:Yty9Vs4F3D6/liF1o6FNt0PvN85h/BJJ6DQKJ3nrcM0=
go.opentelemetry.io/contrib/propagators/b3 v1.20.0/go.mod h1:On4VgbkqYL18kbJlWsa18+cMNe6rYpBnPi1ARI/BrsU=
go.opentelemetry.io/contrib/zpages v0.45.0 h1:jIwHHGoWzJoZdbIUtWdErjL85Gni6BignnAFqDtMRL4=
Expand Down
10 changes: 2 additions & 8 deletions plugin/storage/grpc/config/config.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,7 @@ func (c *Configuration) Close() error {

func (c *Configuration) buildRemote(logger *zap.Logger, tracerProvider trace.TracerProvider) (*ClientPluginServices, error) {
opts := []grpc.DialOption{
grpc.WithUnaryInterceptor(
otelgrpc.UnaryClientInterceptor(otelgrpc.WithTracerProvider(tracerProvider))),
grpc.WithStreamInterceptor(
otelgrpc.StreamClientInterceptor(otelgrpc.WithTracerProvider(tracerProvider))),
grpc.WithStatsHandler(otelgrpc.NewClientHandler(otelgrpc.WithTracerProvider(tracerProvider))),
grpc.WithBlock(),
}
if c.RemoteTLS.Enabled {
Expand Down Expand Up @@ -127,10 +124,7 @@ func (c *Configuration) buildRemote(logger *zap.Logger, tracerProvider trace.Tra

func (c *Configuration) buildPlugin(logger *zap.Logger, tracerProvider trace.TracerProvider) (*ClientPluginServices, error) {
opts := []grpc.DialOption{
grpc.WithUnaryInterceptor(
otelgrpc.UnaryClientInterceptor(otelgrpc.WithTracerProvider(tracerProvider))),
grpc.WithStreamInterceptor(
otelgrpc.StreamClientInterceptor(otelgrpc.WithTracerProvider(tracerProvider))),
grpc.WithStatsHandler(otelgrpc.NewClientHandler(otelgrpc.WithTracerProvider(tracerProvider))),
}

tenancyMgr := tenancy.NewManager(&c.TenancyOpts)
Expand Down

0 comments on commit 3acbdcd

Please sign in to comment.