-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[chore][deps] Bump otel-collector to 0.113.0 and fix failing unit test (
#6197) ## Which problem is this PR solving? - Continuation of #6175. - There was a breaking change made in open-telemetry/opentelemetry-collector#11575 that updates `ToClientConn` to use `DialContext` instead of `NewClient` because of a bug. `DialContext` uses the `passthrough` scheme was resulting in the following error when the endpoint is left empty. This PR fixes the unit tests by setting the endpoint in the test configs to be non-empty. ``` grpc storage builder failed to create a store: error creating traced remote storage client: failed to exit idle mode: passthrough: received empty target in Build() ``` ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Mahad Zaryab <[email protected]> Signed-off-by: Mahad Zaryab <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Loading branch information
1 parent
81397e5
commit 7d637a6
Showing
3 changed files
with
289 additions
and
272 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.