-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix batchProcessor to set correct span format flags #4796
Fix batchProcessor to set correct span format flags #4796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please sign your commit.
Yep, already did |
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
1e9f689
to
42ef373
Compare
@albertteoh could you approve the required workflows please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add unit test that illustrates the issue
Signed-off-by: Alexander Kozlov <[email protected]>
fd50c2b
to
5e61d08
Compare
Added unit test |
Signed-off-by: Yuri Shkuro <[email protected]>
…l/jaeger into Fix-proto-label-in-collector-metrics Signed-off-by: Yuri Shkuro <[email protected]>
Thanks! |
Which problem is this PR solving?
Recently I've noticed that collector sends wrong tags "format" and "transport" in metric
jaeger_collector_spans_received_total
.Root cause: when batchProcessor was extended to be called from OTLP Receiver, it was given SpanOptions parameter that could specify a different span format OTLP, vs. always setting Proto. But the processor was still using hardcoded Proto format when invoking the next processor.
How was this change tested?
Added unit test
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test